Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell people to use --with-modules=... when they use --without-mysql #7335

Merged
merged 1 commit into from
Jan 18, 2019

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jan 7, 2019

closes #5140

Short description

Detect --without-mysql and suggest --with-modules="bind random" --with-dyn-modules="pipe"

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

fwiw, this isn't my preference, I'd rather we just remove gmysql from modules when someone uses --without-mysql, but...

$ ./configure --without-mysql --with-libcrypto=/usr/local/opt/openssl 2>&1|tail -5
checking for arc4random... yes
checking whether to enable verbose logging... no
checking whether to enable PKCS11 support... no
checking whether to enable experimental GSS-TSIG support... no
configure: error: instead of --without-mysql try --with-modules="bind random" --with-dyn-modules="pipe"

@rgacogne rgacogne added this to the auth-4.2.0 milestone Jan 7, 2019
@pieterlexis
Copy link
Contributor

As discussed on IRC, please make --without-mysql an error condition as we only attempt to find it when we really need it.

Copy link
Contributor

@pieterlexis pieterlexis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pieterlexis pieterlexis merged commit b6b0d7f into PowerDNS:master Jan 18, 2019
@jsoref jsoref deleted the issue-5140 branch January 18, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth ./configure --without-mysql should disable the gmysql module
3 participants