Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero out qtype response numbers in our statistics #7348

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Zero out qtype response numbers in our statistics #7348

merged 1 commit into from
Jan 9, 2019

Conversation

ahupowerdns
Copy link
Contributor

Although you might think otherwise, and I frequently do, atomic counters do not get zero-initialized.
With this PR, we do this by hand. This makes valgrind usable again on auth.

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@ahupowerdns
Zero out qtype response numbers in our statistics
8fdfa2c 
Although you might think otherwise, and I frequently do, atomic counters do not get zero-initialized.
With this PR, we do this by hand. This makes valgrind usable again on auth.
@pieterlexis pieterlexis merged commit e73bacc into PowerDNS:master Jan 9, 2019
@aerique aerique added this to the auth-4.2.0-beta1 milestone Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
auth-4.2.0-beta1
Development

Successfully merging this pull request may close these issues.
3 participants
@ahupowerdns @aerique @pieterlexis