Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer filter DNSSEC metadata when DNSSEC is enabled in gsql #7706

Merged
merged 1 commit into from Apr 10, 2019
Merged

No longer filter DNSSEC metadata when DNSSEC is enabled in gsql #7706

merged 1 commit into from Apr 10, 2019

Conversation

ahupowerdns
Copy link
Contributor

@ahupowerdns ahupowerdns commented Apr 10, 2019 •
edited

As noted in #7705, gsql getAllDomainMetadata() did not return all domain
metadata. This function would always filter DNSSEC related metadata, even
if a backend was configured to support DNSSEC.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@ahupowerdns
No longer filter DNSSEC metadata when DNSSEC is enabled in gsql
d97e1ae 
As noted in PowerDNS#7705, gsql getAllDomainMetadata() did not return all domain
metadata.  This function would always filter DNSSEC related metadata, even
if a backend was configured to support DNSSEC.
@ahupowerdns
Copy link
Contributor Author

@mind04 - what do you think?

@ahupowerdns ahupowerdns merged commit 902e05f into PowerDNS:master Apr 10, 2019
@ahupowerdns ahupowerdns deleted the unfilter-allmetadata branch April 11, 2019 08:06
@Habbie Habbie mentioned this pull request May 14, 2019
Closed
@Habbie Habbie mentioned this pull request Jun 12, 2019
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mind04 mind04 mind04 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahupowerdns @mind04