Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Reuse the outgoing query protobuf for the incoming response #7901

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

rgacogne
Copy link
Member

Short description

Allocating memory for the ProtoBuf objects an their fields is costly, as is converting the qname and potential UUID to strings, for example.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne
Copy link
Member Author

CircleCI failure seems unrelated, probably #7899 ?

@Habbie
Copy link
Member

Habbie commented Jun 11, 2019

CircleCI failure seems unrelated, probably #7899 ?

yes

@omoerbeek omoerbeek self-requested a review June 11, 2019 12:54
Copy link
Member

@omoerbeek omoerbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only logging answers an no replies is not possible.

It can be a good thing to de-couple this and be able to only log one of the two. As the reply contains the request data the former is enough in some scenarios.

(The dnstap code allows switching on an off for queries and replies independently).

@rgacogne
Copy link
Member Author

Only logging answers an no replies is not possible.

I noticed that as well and was a bit surprised about it because we do support it for the logging of incoming queries and outgoing responses, but I considered it was out of scope for this PR.

@omoerbeek omoerbeek merged commit 7fb3b5b into PowerDNS:master Jun 14, 2019
@rgacogne rgacogne deleted the rec-reuse-pb-messages branch June 14, 2019 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants