Remote Backend: Throw DBException in functions that allow it

[pieterlexis]

Short description

These functions are called inside a try block in e.g. the
slavecommunicator and them throwing actually makes the reporting
better.

Checklist

I have:

• read the CONTRIBUTING.md document
• compiled this code
• tested this code
• included documentation (including possible behaviour changes)
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)

[rgacogne]

Out if curiosity, did you consider making RemoteBackend::send() and RemoteBackend::recv() throw instead? It might solve #8866 as well.

[pieterlexis]

Out if curiosity, did you consider making RemoteBackend::send() and RemoteBackend::recv() throw instead? It might solve #8866 as well.

I was afraid with blowing up the auth process on a failure.. but it looks like the database backend do the same as well. I will change this PR to indeed throw on send and recv failures.

[pieterlexis]

hhrm, by the looks of the CI, throwing on {"result": false} might be a bit too much :)

[rgacogne]

hhrm, by the looks of the CI, throwing on {"result": false} might be a bit too much :)

That's a valid result for some operations, I believe?

[pieterlexis]

That's a valid result for some operations, I believe?

it is

[cmouse]

should this be DBException instead?

[pieterlexis]

hmm, I typed that in, but I think blowing up the connection on a 404 is a bit much.....

[cmouse]

uhm, the if condition precludes 404, so it's not blowing up the connection.. I am bit puzzled how 404's are treated now.

[cmouse]

should there be unit/integration test for that?

[pieterlexis]

uhm, the if condition precludes 404, so it's not blowing up the connection.. I am bit puzzled how 404's are treated now.

ah yes :)

should there be unit/integration test for that?

It is implicitly tested, as I got exceptions on 404s before :)

[Habbie]

This looks resolved to me, except for the exception type, right?

[Habbie]

Title says DBException, code says PDNSException, I trust the title is outdated?

[pieterlexis]

Title says DBException, code says PDNSException, I trust the title is outdated?

We use PDNSExceptions to signal problems, when they aren't recoverable by the backend, we throw a DBException toward the Ueberbackend.

[Habbie]

We use PDNSExceptions to signal problems, when they aren't recoverable by the backend, we throw a DBException toward the Ueberbackend.

Oh, I see now that the code does both. Ok!