Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Get rid of allocations in the packet cache's fast path #9420

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

rgacogne
Copy link
Member

Short description

I stumbled upon unneeded memory allocations and copies while doing benchmarks to asses the impact of #8993.
Getting rid of them delivers a nice speed-up, up to ~40% in unrealistic micro-benchmarks, likely much less in practice.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

This delivers a nice speed-up, up to ~40% in unrealistic micro-benchmarks,
likely much less in practice.
@rgacogne rgacogne merged commit 22bbe9c into PowerDNS:master Aug 31, 2020
@rgacogne rgacogne deleted the ddist-pc-no-allocs branch August 31, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants