Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Handle empty DNSNames in grepq() #9431

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Sep 1, 2020

Short description

We should not get an empty DNSName into the ring buffer, but let's
handle it gracefully if it does happen so we can investigate, instead
of getting:

Caught exception: empty dnsnames aren't part of anything

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

We should not get an empty DNSName into the ring buffer, but let's
handle it gracefully if it does happen so we can investigate, instead
of getting:

Caught exception: empty dnsnames aren't part of anything
@rgacogne rgacogne added this to the dnsdist-1.6.0 milestone Sep 1, 2020
@rgacogne rgacogne merged commit 7d452dc into PowerDNS:master Sep 1, 2020
@rgacogne rgacogne deleted the ddist-grepq-empty-names branch September 1, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant