Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Fix a crash when a DoH responses map is updated at runtime #9934



Copy link

Short description

We now use reference counting so that the response map is only destroyed after all readers are done with it. Previously updating the map meant that the underlying data was destroyed right away, while it might have been in use by DoH connection handler threads.
Fixes #9927 in my tests.


I have:

  • read the document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne merged commit 7bf0aa2 into PowerDNS:master Jan 12, 2021
@rgacogne rgacogne deleted the ddist-fix-crash-doh-responses-map branch January 12, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

dnsdist segfaults in
2 participants