Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build musllinux 1.2 in the pipeline #281

Merged
merged 4 commits into from
Jun 23, 2023
Merged

Build musllinux 1.2 in the pipeline #281

merged 4 commits into from
Jun 23, 2023

Conversation

TonyXiang8787
Copy link
Member

Problem

The official musllinux_1_1 image has an old compiler (GCC 9.3) which does not support many C++20 feature.

Final Solution

If official musllinux_1_2 image is published, we can use (hopefully) GCC 12.2.

Work around solution

We now build musllinux_1_2 separately in the image python:3.9-alpine3.17, which has GCC 12.2

Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know when musllinux_1_2 is expected?

setup.py Show resolved Hide resolved
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
Copy link
Member Author

do you know when musllinux_1_2 is expected?

@mgovers I have no idea.

@mgovers mgovers enabled auto-merge June 23, 2023 10:33
@mgovers mgovers disabled auto-merge June 23, 2023 10:36
@mgovers mgovers enabled auto-merge June 23, 2023 10:36
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mgovers mgovers merged commit af06ed2 into main Jun 23, 2023
26 checks passed
@mgovers mgovers deleted the feature/musllinux-1.2 branch June 23, 2023 11:40
@mgovers mgovers mentioned this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants