-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/remove enable if #282
Feature/remove enable if #282
Conversation
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
…idModel/power-grid-model into feature/remove-enable-if
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers please have a look at the build guide. To see if the required C++ standard and compiler version needs to be updated. |
According to the build guide:
According to https://en.cppreference.com/w/cpp/compiler_support/20 , GCC has full support for concepts starting with GCC 10 and onward, so in that sense we shouldn't have to update the docs. However, the build guide still refers to |
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
|
oh sorry apparently i was looking at an older thread (pypa/manylinux#1282). will fix. should we also bump the gcc version in CI? |
You mean in the documentation or in CI itself? |
CI itself, i mean. i'm fine either way but want to double-check |
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
I think it is good to update the CI compiler version to the newest. |
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/sparse_lu_solver.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/three_phase_tensor.hpp
Outdated
Show resolved
Hide resolved
There is a work around to counter a GCC 10 bug. Line 26 in 0a19677
Since we upgrade to GCC 12, that work around can be removed. |
now that i think about it, we'd better bump CI compiler versions in a separate PR because it may cause other not-yet-seen issues and i would like to isolate changes |
Okay. After you add comment for |
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Kudos, SonarCloud Quality Gate passed! |
e93174d
into
release/short-circuit-calculation
modernize: remove
std::enable_if
in multiple places (cfr. #276 and made possible by #281 )Resolves sonar cloud issues: