fix multiple different code smells

[Laurynas-Jagutis]

Fixed:

• Most of "Remove this redundant cast."
• All "Extract this nested conditional operator into an independent statement"

[mgovers]

FYI: your CI fails because of a known issue in the ubuntu container (more specifically with the combination clang + libstdc++). Re-running failed jobs should do the trick (maybe twice).

The specific issue causes this log, so if you see this, then you know that's what's wrong:

      /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/chrono:2320:48: note: undefined function '_S_fractional_width' cannot be used in a constant expression
      /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/chrono:2275:2: note: declared here
              _S_fractional_width()
              ^
      1 error generated.

[Laurynas-Jagutis]

FYI: your CI fails because of a known issue in the ubuntu container (more specifically with the combination clang + libstdc++). Re-running failed jobs should do the trick (maybe twice).

The specific issue causes this log, so if you see this, then you know that's what's wrong:

      /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/chrono:2320:48: note: undefined function '_S_fractional_width' cannot be used in a constant expression
      /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/chrono:2275:2: note: declared here
              _S_fractional_width()
              ^
      1 error generated.

Tried rerunning the failed jobs multiple times now, did not help.

[mgovers]

FYI: your CI fails because of a known issue in the ubuntu container (more specifically with the combination clang + libstdc++). Re-running failed jobs should do the trick (maybe twice).
The specific issue causes this log, so if you see this, then you know that's what's wrong:

      /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/chrono:2320:48: note: undefined function '_S_fractional_width' cannot be used in a constant expression
      /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/chrono:2275:2: note: declared here
              _S_fractional_width()
              ^
      1 error generated.

Tried rerunning the failed jobs multiple times now, did not help.

can you please change the base to feature/llvm-15-in-ci and merge that branch into this one? the fix in #418 should do the trick

[mgovers]

@Laurynas-Jagutis please change the base branch as well (edit the PR), because otherwise, your PR will contain those changes as well, which is undesirable

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication