Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix multiple different code smells #417

Merged
merged 13 commits into from
Oct 31, 2023
Merged

fix multiple different code smells #417

merged 13 commits into from
Oct 31, 2023

Commits on Oct 30, 2023

  1. fix multiple different code smells 

    Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
    @Laurynas-Jagutis
    Laurynas-Jagutis committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    9fdaa2b View commit details
    Browse the repository at this point in the history

  2. revert change with namespaces 

    Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
    @Laurynas-Jagutis
    Laurynas-Jagutis committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    2c050df View commit details
    Browse the repository at this point in the history

  3. move function to private 

    Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
    @Laurynas-Jagutis
    Laurynas-Jagutis committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    e16b1af View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. return the cast to double 

    Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
    @Laurynas-Jagutis
    Laurynas-Jagutis committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    946f27e View commit details
    Browse the repository at this point in the history

  2. fix multiple different code smells 

    Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
    @Laurynas-Jagutis
    Laurynas-Jagutis committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    f533d30 View commit details
    Browse the repository at this point in the history

  3. revert change with namespaces 

    Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
    @Laurynas-Jagutis
    Laurynas-Jagutis committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    7edaa71 View commit details
    Browse the repository at this point in the history

  4. move function to private 

    Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
    @Laurynas-Jagutis
    Laurynas-Jagutis committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    9663ac6 View commit details
    Browse the repository at this point in the history

  5. return the cast to double 

    Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
    @Laurynas-Jagutis
    Laurynas-Jagutis committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    00bb926 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'feature/code-smells-fix' of https://github.com/PowerGri… 

    …dModel/power-grid-model into feature/code-smells-fix
    @Laurynas-Jagutis
    Laurynas-Jagutis committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    4746485 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into feature/code-smells-fix 

    Signed-off-by: Martijn Govers <martijn.govers@alliander.com>
    @mgovers
    mgovers committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    dee075e View commit details
    Browse the repository at this point in the history

  8. change get_name 

    Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
    @Laurynas-Jagutis
    Laurynas-Jagutis committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    62633fb View commit details
    Browse the repository at this point in the history

  9. Merge branch 'feature/code-smells-fix' of https://github.com/PowerGri… 

    …dModel/power-grid-model into feature/code-smells-fix
    @Laurynas-Jagutis
    Laurynas-Jagutis committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    38cc978 View commit details
    Browse the repository at this point in the history

  10. update n_col function 

    Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
    @Laurynas-Jagutis
    Laurynas-Jagutis committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    6cc40a9 View commit details
    Browse the repository at this point in the history