Improve formatting component modeling documentation #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhen Wang <zhen.wang@alliander.com>
mgovers
changed the title
mgovers
reviewed
Nov 27, 2023
|
only semi-related to this PR, but the docs for each of the components are becoming fairly large. Do you think it would be a good idea to collapse/expand sections? documentation on how to add that in https://sphinx-toolbox.readthedocs.io/en/stable/extensions/collapse.html |
mgovers
reviewed
Nov 29, 2023
Signed-off-by: Zhen Wang <zhen.wang@alliander.com>
|
Is this DCO remediation broken? :( |
Signed-off-by: Zhen Wang <zhen.wang@alliander.com>
Signed-off-by: Zhen Wang <zhen.wang@alliander.com>
DCO Remediation Commit for Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com> I, Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 6a118e5 Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com> Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> DCO Remediation Commit for Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com> I, Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 6a118e5 Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com> Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> DCO Remediation Commit for Nitish Bharambe <nitish.bharambe@alliander.com> I, Nitish Bharambe <nitish.bharambe@alliander.com>, hereby add my Signed-off-by to this commit: 6a118e5 Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> remediation final try DCO Remediation Commit for Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com> I, Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 6a118e5 Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com> Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers
force-pushed
the
feature/document-modeling
branch
from
07062e9
to
52f886d
Compare
nitbharambe
previously approved these changes
Dec 4, 2023
mgovers
reviewed
Dec 4, 2023
nitbharambe
reviewed
Dec 4, 2023
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
mgovers
reviewed
Dec 11, 2023
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
Signed-off-by: Zhen Wang <zhen.wang@alliander.com>
Signed-off-by: Zhen Wang <zhen.wang@alliander.com>
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
nitbharambe
reviewed
Dec 11, 2023
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
nitbharambe
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterate on #428 .
Preview in https://power-grid-model--439.org.readthedocs.build/en/439/user_manual/components.html
Closes #375