Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preliminary equations #428

Merged
merged 13 commits into from Nov 24, 2023
Merged

preliminary equations #428

merged 13 commits into from Nov 24, 2023

Conversation

zhen0427
Copy link
Contributor

Fixes issue: # name and number of the issue

Changes proposed in this PR include:

Here you can elaborate on the chosen solution strategy, which changes did you make and which goal do they serve. Perhaps also which things are you still unsure of.

  • ..

Could you please pay extra attention to the points below when reviewing the PR:

Here you can point out modules or complex implementation that require special attention, .e.g have a look at module foo.py and bar.py.

  • ..

@nitbharambe nitbharambe self-requested a review November 17, 2023 08:26
Signed-off-by: Zhen Wang <zhen.wang@alliander.com>
Signed-off-by: Zhen Wang <zhen.wang@alliander.com>
Signed-off-by: Zhen Wang <zhen.wang@alliander.com>
Signed-off-by: Zhen Wang <zhen.wang@alliander.com>
Signed-off-by: Zhen Wang <zhen.wang@alliander.com>
DCO Remediation Commit for Zhen Wang <zhen.wang@alliander.com>

I, Zhen Wang <zhen.wang@alliander.com>, hereby add my Signed-off-by to this commit: c3ff31b

Signed-off-by: Zhen Wang <zhen.wang@alliander.com>

Signed-off-by: Zhen Wang <zhen.wang@alliander.com>
Signed-off-by: Zhen Wang <zhen.wang@alliander.com>
Signed-off-by: Zhen Wang <zhen.wang@alliander.com>
@zhen0427 zhen0427 marked this pull request as ready for review November 22, 2023 10:51
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
Copy link

sonarcloud bot commented Nov 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nitbharambe nitbharambe merged commit 2cd6263 into main Nov 24, 2023
27 checks passed
@nitbharambe nitbharambe deleted the feature/document-modeling branch November 24, 2023 10:46
@mgovers
Copy link
Member

mgovers commented Nov 27, 2023

probably nitpicking but in the equations i see some formatting things that could very easily be improved to make it more readable. E.g.:

image

here, substituting tan \sigma -> \tan \sigma will render it as
image

Similarly,

Y_\mathrm{series} & = & 1 & \times 10^6 * ( 1+ \mathrm{j} ) p.u. &.
image

may be rendered as Y_{\text{series}} = (1 + \mathrm{j}) \cdot 10^6 \,\mathrm{p.u.}

image

In addition, some underscores making the 0 as an index may be very welcome in cases like this:
image

Do you think it's a good idea to create a follow-up PR to go over those little things?

@nitbharambe
Copy link
Member

probably nitpicking but in the equations i see some formatting things that could very easily be improved to make it more readable. E.g.:

image

here, substituting tan \sigma -> \tan \sigma will render it as image

Similarly,

Y_\mathrm{series} & = & 1 & \times 10^6 * ( 1+ \mathrm{j} ) p.u. &. image

may be rendered as Y_{\text{series}} = (1 + \mathrm{j}) \cdot 10^6 \,\mathrm{p.u.}

image

In addition, some underscores making the 0 as an index may be very welcome in cases like this: image

Do you think it's a good idea to create a follow-up PR to go over those little things?

Lets leave the i0 part as thats the actual attribute of PGM, makes it easier to grasp

@mgovers
Copy link
Member

mgovers commented Nov 27, 2023

probably nitpicking but in the equations i see some formatting things that could very easily be improved to make it more readable. E.g.:
image
here, substituting tan \sigma -> \tan \sigma will render it as image
Similarly,
Y_\mathrm{series} & = & 1 & \times 10^6 * ( 1+ \mathrm{j} ) p.u. &. image
may be rendered as Y_{\text{series}} = (1 + \mathrm{j}) \cdot 10^6 \,\mathrm{p.u.}
image
In addition, some underscores making the 0 as an index may be very welcome in cases like this: image
Do you think it's a good idea to create a follow-up PR to go over those little things?

Lets leave the i0 part as thats the actual attribute of PGM, makes it easier to grasp

then please make it mono-space or put it in square brackets or something, because it does become confusing when dealing with multiple variables that may be multiplied, especially for sn and sn^2. e.g.:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants