-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor main core + initial setup for tap regulator input/output #565
Conversation
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/output.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/output.hpp
Show resolved
Hide resolved
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some are comments on existing codes prior to this PR.
power_grid_model_c/power_grid_model/include/power_grid_model/common/exception.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/common/exception.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/component/branch.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/component/branch3.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/output.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/output.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/output.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/output.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/output.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_model.hpp
Show resolved
Hide resolved
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Quality Gate failedFailed conditions |
Not sure if any new tests are needed for the code coverage |
not really necessary. there are no tests specifically about I/O currently in the first place. coverage will be reached once main model integration tests + validation tests are created |
BTW: pulling |
That is noice. I was under the impression only conflicts between branchs in queue were addressed with this. |
that was the case until tony and I unchecked the |
So long story short: do it anyways... |
only if there's a good reason 😬 |
Relates to #74
Relates to #557
I needed this work for #557 but I deemed it out of scope of that PR, so I cherry-picked the changes and applied them here.
@nitbharambe maybe this will help you with #562 as well