Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/improve and test floating points in exception message #649

Merged
merged 9 commits into from
Jun 21, 2024
Merged

Feature/improve and test floating points in exception message #649

merged 9 commits into from
Jun 21, 2024

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Jun 21, 2024

Improve error message with floating point values

Before:

Iteration failed to converge after 20 iterations! Max deviation: 0.000000, error tolerance: 0.000000.

Try validate_input_data() or validate_batch_data() to validate your data.

After:

Iteration failed to converge after 20 iterations! Max deviation: 3.54512e-16, error tolerance: 1e-20.

Try validate_input_data() or validate_batch_data() to validate your data.

@figueroa1395 since I reran the notebook, you will run into some merge conflicts. On your branch, just make sure you're on the latest PGM core version. To resolve the merge conflict, just run git add docs/examples && git reset docs/examples && git checkout docs/examples and re-run all of them

@mgovers
fix test exceptions on iteration diverge
bf644da 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
improve error messages for tests
f51cb9c 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
rerun power flow example
b5ef432 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
rerun notebooks
13524a6 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers self-assigned this Jun 21, 2024
@mgovers mgovers added the bug Something isn't working label Jun 21, 2024
@mgovers
Update power_grid_model_c/power_grid_model/include/power_grid_model/c…
f65545d 
…ommon/exception.hpp


Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

Signed-off-by: Martijn Govers <martygovers@hotmail.com>
@mgovers
Update power_grid_model_c/power_grid_model/include/power_grid_model/c…
46a7143 
…ommon/exception.hpp


Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

Signed-off-by: Martijn Govers <martygovers@hotmail.com>
@mgovers
Update power_grid_model_c/power_grid_model/include/power_grid_model/c…
f1d27f4 
…ommon/exception.hpp


Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

Signed-off-by: Martijn Govers <martygovers@hotmail.com>
@mgovers
Update power_grid_model_c/power_grid_model/include/power_grid_model/c…
ff5aade 
…ommon/exception.hpp


Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

Signed-off-by: Martijn Govers <martygovers@hotmail.com>
mgovers
mgovers commented Jun 21, 2024
View reviewed changes
tests/c_api_tests/test_serialization.cpp Outdated Show resolved Hide resolved
tests/c_api_tests/test_serialization.cpp Outdated Show resolved Hide resolved
@mgovers
Update tests/c_api_tests/test_serialization.cpp
07ef85f 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

Signed-off-by: Martijn Govers <martygovers@hotmail.com>
Jerry-Jinfeng-Guo
Jerry-Jinfeng-Guo approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title is not the most descriptive one unfortunately ;)

@mgovers mgovers changed the title Feature/improve test exceptions Feature/improve and test floating points in exception message Jun 21, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added this pull request to the merge queue Jun 21, 2024
Merged via the queue into main with commit be48867 Jun 21, 2024
26 checks passed
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo deleted the feature/improve-test-exceptions branch June 21, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo approved these changes

@nitbharambe nitbharambe nitbharambe approved these changes

@figueroa1395 figueroa1395 Awaiting requested review from figueroa1395

@zhen0427 zhen0427 Awaiting requested review from zhen0427

Assignees

@mgovers mgovers

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgovers @Jerry-Jinfeng-Guo @nitbharambe