PN-89 Makes the anvil ignore the enchantment order. Fix #239

It will accept the client's ordering if the actual enchantments
and everything else are the same.

src/main/java/cn/nukkit/inventory/transaction/CraftingTransaction.java

@@ -8,9 +8,13 @@
 import cn.nukkit.inventory.transaction.action.SlotChangeAction;
 import cn.nukkit.inventory.transaction.action.TakeLevelAction;
 import cn.nukkit.item.Item;
+import cn.nukkit.nbt.tag.CompoundTag;
+import cn.nukkit.nbt.tag.ListTag;
 import cn.nukkit.network.protocol.ContainerClosePacket;
 import cn.nukkit.network.protocol.types.ContainerIds;
 import cn.nukkit.scheduler.Task;
+import it.unimi.dsi.fastutil.ints.Int2IntArrayMap;
+import it.unimi.dsi.fastutil.ints.Int2IntMap;
 
 import java.util.Arrays;
 import java.util.List;
@@ -155,7 +159,7 @@ public boolean canExecute() {
             if (inventory instanceof AnvilInventory) {
                 AnvilInventory anvil = (AnvilInventory) inventory;
                 addInventory(anvil);
-                if (this.primaryOutput.equals(anvil.getResult(), true, true)) {
+                if (equalsIgnoringEnchantmentOrder(this.primaryOutput, anvil.getResult(), true)) {
                     TakeLevelAction takeLevel = new TakeLevelAction(anvil.getLevelCost());
                     addAction(takeLevel);
                     if (takeLevel.isValid(source)) {
@@ -194,6 +198,56 @@ public boolean canExecute() {
         return this.recipe != null && super.canExecute();
     }
 
+    //TODO Move this to Item at 1.2.1.0-PN
+    @Deprecated
+    private boolean equalsIgnoringEnchantmentOrder(Item thisItem, Item item, boolean checkDamage) {
+        if (!thisItem.equals(item, checkDamage, false)) {
+            return false;
+        }
+
+        if (Arrays.equals(thisItem.getCompoundTag(), item.getCompoundTag())) {
+            return true;
+        }
+
+        if (!thisItem.hasCompoundTag() || !item.hasCompoundTag()) {
+            return false;
+        }
+
+        CompoundTag thisTags = thisItem.getNamedTag();
+        CompoundTag otherTags = item.getNamedTag();
+        if (thisTags.equals(otherTags)) {
+            return true;
+        }
+
+        if (!thisTags.contains("ench") || !otherTags.contains("ench")
+                || !(thisTags.get("ench") instanceof ListTag)
+                || !(otherTags.get("ench") instanceof ListTag)
+                || thisTags.getList("ench").size() != otherTags.getList("ench").size()) {
+            return false;
+        }
+
+        ListTag<CompoundTag> thisEnchantmentTags = thisTags.getList("ench", CompoundTag.class);
+        ListTag<CompoundTag> otherEnchantmentTags = otherTags.getList("ench", CompoundTag.class);
+
+        int size = thisEnchantmentTags.size();
+        Int2IntMap enchantments = new Int2IntArrayMap(size);
+        enchantments.defaultReturnValue(Integer.MIN_VALUE);
+
+        for (int i = 0; i < size; i++) {
+            CompoundTag tag = thisEnchantmentTags.get(i);
+            enchantments.put(tag.getShort("id"), tag.getShort("lvl"));
+        }
+
+        for (int i = 0; i < size; i++) {
+            CompoundTag tag = otherEnchantmentTags.get(i);
+            if (enchantments.get(tag.getShort("id")) != tag.getShort("lvl")) {
+                return false;
+            }
+        }
+
+        return true;
+    }
+
     protected boolean callExecuteEvent() {
         CraftItemEvent ev;