Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't combine (Thorns2,Unbreaking3)+(Protection3,Unbreaking3) in anvil #239

Closed
joserobjr opened this issue May 9, 2020 · 4 comments
Closed

Can't combine (Thorns2,Unbreaking3)+(Protection3,Unbreaking3) in anvil #239

joserobjr opened this issue May 9, 2020 · 4 comments
Assignees
@joserobjr
Labels
Resolution: resolved The issue has been addressed or the request has been accepted Type: bug Something isn't working
Milestone
1.2.0.2-PN

Comments

@joserobjr
Copy link
Member

joserobjr commented May 9, 2020 •
edited

🐞 I found a bug

▶ Steps to Reproduce

Input Sacrifice
image image

✔ Expected Behavior

image

❌ Actual Behavior

You can't grab the result (the transaction is cancelled)

📋 Debug information

💬 Anything else we should know?

Reported by @AntonPPDS at #222 (comment)
@joserobjr joserobjr added the Type: bug Something isn't working label May 9, 2020
@joserobjr joserobjr added this to the 1.2.0.2-PN milestone May 9, 2020
@joserobjr joserobjr self-assigned this May 9, 2020
@joserobjr
Copy link
Member Author

🕷 Cause:

Java Edition preserves the enchantment insertion order but Bedrock Edition reorder them.

@joserobjr joserobjr modified the milestones: 1.2.0.2-PN, 1.2.1.0-PN May 9, 2020
@joserobjr
Copy link
Member Author

The order:
image

Missing:
fire_protection
frost_walker
mending
piercing
projectile_protection
protection
riptide
sharpness
silk_touch
smite

@joserobjr
Copy link
Member Author

Oh no! Bedrock ordering are unreliable.

Oh No!
image image

I'm going to make the anvil logic ignore the order.

joserobjr added a commit that referenced this issue May 10, 2020
@joserobjr
PN-89 Failed attempt to fix #239
5bc617a
@joserobjr joserobjr mentioned this issue May 10, 2020
Merged
joserobjr added a commit that referenced this issue May 10, 2020
@joserobjr
PN-89 Adds #239 to the changelog
9a517c1
@joserobjr joserobjr mentioned this issue May 10, 2020
Merged
@joserobjr joserobjr added the Resolution: resolved The issue has been addressed or the request has been accepted label May 10, 2020
@joserobjr joserobjr modified the milestones: 1.2.1.0-PN, 1.2.0.2-PN May 10, 2020
@AntonPPDS
Copy link

It seems the order of echantments is somehow related to the compatibility with item. I.e., if this is armor echantment on armor, it would be the most first, but I'm not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joserobjr joserobjr

Labels
Resolution: resolved The issue has been addressed or the request has been accepted Type: bug Something isn't working
Projects
None yet
Milestone
1.2.0.2-PN
Development

No branches or pull requests
2 participants
@joserobjr @AntonPPDS