Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.X] Incorrect explosion behaviour with waterlogged blocks. #193

Closed
joserobjr opened this issue Feb 12, 2020 · 3 comments
Closed

[1.X] Incorrect explosion behaviour with waterlogged blocks. #193

joserobjr opened this issue Feb 12, 2020 · 3 comments
Assignees
@joserobjr @Gabriel8579
Labels
Resolution: resolved The issue has been addressed or the request has been accepted Type: bug Something isn't working
Milestone
1.2.0.2-PN

Comments

@joserobjr
Copy link
Member

joserobjr commented Feb 12, 2020 •
edited

Comparison on the links bellow (provided by @Gabriel8579). This issue will treat the 1.X behavior and #192 the 2.X version.
@Gabriel8579 Gabriel8579 self-assigned this Feb 12, 2020
@Gabriel8579
Copy link
Member

https://youtu.be/efLHclbVvV4 Comparing vanilla with 1.1.x (master branch)

@joserobjr
Copy link
Member Author

2.X test result: #192 (comment)

I'm also going to try to fix it tonight. Thanks!

@joserobjr joserobjr mentioned this issue Feb 12, 2020
Closed
@joserobjr joserobjr changed the title Test if dropped items in waterlogged blocks can be destroyed [1.X] Incorrect explosion behaviour with waterlogged blocks. Feb 12, 2020
@joserobjr joserobjr self-assigned this Feb 12, 2020
@joserobjr joserobjr added the Type: bug Something isn't working label Feb 12, 2020
@joserobjr joserobjr added this to the 1.2.0.0-PN milestone Feb 12, 2020
@joserobjr
Copy link
Member Author

Related: NukkitX#1184

@joserobjr joserobjr mentioned this issue Feb 15, 2020
Merged
joserobjr added a commit that referenced this issue May 10, 2020
@joserobjr
PN-64 Fixes #193 explosion behaviour with waterlogged block
42d65b6
joserobjr added a commit that referenced this issue May 10, 2020
@joserobjr
PN-63 Fixes #193 explosion behaviour with waterlogged block
cfb3e86
joserobjr added a commit that referenced this issue May 10, 2020
@joserobjr
PN-63 Adds #193 to the changelog
d7cab8b
@joserobjr joserobjr mentioned this issue May 10, 2020
Merged
@joserobjr joserobjr added the Resolution: resolved The issue has been addressed or the request has been accepted label May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joserobjr joserobjr

@Gabriel8579 Gabriel8579

Labels
Resolution: resolved The issue has been addressed or the request has been accepted Type: bug Something isn't working
Projects
None yet
Milestone
1.2.0.2-PN
Development

No branches or pull requests
2 participants
@joserobjr @Gabriel8579