Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignores the meta in air blocks when rendering to the client #248

Merged
merged 2 commits into from May 10, 2020
Merged

Ignores the meta in air blocks when rendering to the client #248

merged 2 commits into from May 10, 2020

Conversation

joserobjr
Copy link
Member

@joserobjr joserobjr commented May 10, 2020 •
edited

Fixes the world in the screenshot of #210

It had a lot of air blocks with metadata set:

18:09:50 [ERROR] Found an unknown BlockId:Meta combination: 0:5, replacing with an "UPDATE!" block.
18:09:50 [ERROR] Found an unknown BlockId:Meta combination: 0:2, replacing with an "UPDATE!" block.
18:09:50 [ERROR] Found an unknown BlockId:Meta combination: 0:8, replacing with an "UPDATE!" block.
18:09:50 [ERROR] Found an unknown BlockId:Meta combination: 0:1, replacing with an "UPDATE!" block.
18:09:50 [ERROR] Found an unknown BlockId:Meta combination: 0:13, replacing with an "UPDATE!" block.
18:09:50 [ERROR] Found an unknown BlockId:Meta combination: 0:4, replacing with an "UPDATE!" block.
18:09:50 [ERROR] Found an unknown BlockId:Meta combination: 0:6, replacing with an "UPDATE!" block.
18:09:50 [ERROR] Found an unknown BlockId:Meta combination: 0:3, replacing with an "UPDATE!" block.
18:09:50 [ERROR] Found an unknown BlockId:Meta combination: 0:7, replacing with an "UPDATE!" block.
18:09:50 [ERROR] Found an unknown BlockId:Meta combination: 0:12, replacing with an "UPDATE!" block.
18:09:51 [ERROR] Found an unknown BlockId:Meta combination: 0:10, replacing with an "UPDATE!" block.
18:09:51 [ERROR] Found an unknown BlockId:Meta combination: 0:9, replacing with an "UPDATE!" block.
18:09:51 [ERROR] Found an unknown BlockId:Meta combination: 0:14, replacing with an "UPDATE!" block.
18:09:51 [ERROR] Found an unknown BlockId:Meta combination: 0:15, replacing with an "UPDATE!" block.
18:09:51 [ERROR] Found an unknown BlockId:Meta combination: 0:11, replacing with an "UPDATE!" block.

@joserobjr joserobjr added the Type: bug Something isn't working label May 10, 2020
@joserobjr joserobjr added this to the 1.2.0.2-PN milestone May 10, 2020
@joserobjr joserobjr self-assigned this May 10, 2020
@joserobjr joserobjr added the Resolution: resolved The issue has been addressed or the request has been accepted label May 10, 2020
@joserobjr joserobjr merged commit 3b4ab0e into snapshot/v1.2.0.x May 10, 2020
@joserobjr joserobjr deleted the PN-96 branch May 10, 2020 22:05
@joserobjr joserobjr mentioned this pull request Jul 11, 2020
Closed
joserobjr added a commit that referenced this pull request Jul 11, 2020
@joserobjr
Fix #357, regression of #210 #248 air blocks with meta by FAWE
e589e32
joserobjr added a commit that referenced this pull request Jul 14, 2020
@joserobjr
#356 Fixes regression of #358 #210 #248
341a1ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joserobjr joserobjr

Labels
Resolution: resolved The issue has been addressed or the request has been accepted Type: bug Something isn't working
Projects
None yet
Milestone
1.2.0.2-PN
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@joserobjr