Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#26 Open SelectionPane after editing name #1781

Conversation

ChesterSng
Copy link
Contributor

Fixes #26

Outline of Solution

Open selection pane after user edits the name of a shape

@leeyh20
Copy link
Contributor

leeyh20 commented Feb 14, 2019

Looks good but might need to test on all three versions of PPT to make sure the selection pane has the same idMso across the versions.

@ChesterSng
Copy link
Contributor Author

Yeah I think it might have some issues with 2010.

@YuPeiHenry
Copy link
Contributor

Tested and working on PPT2010.

@blewjy
Copy link
Contributor

blewjy commented Feb 16, 2019

Hey @ChesterSng, this feature is working on PPT2016.

However, you may want to add this check so that the Selection Pane remains open if user were to edit the shape's name when the pane is already open

if (!this.GetApplication().CommandBars.GetPressedMso("SelectionPane"))
{
	this.GetApplication().CommandBars.ExecuteMso("SelectionPane");
}

@ChesterSng
Copy link
Contributor Author

Thanks @blewjy! Changed it so it now works as expected

blewjy
blewjy previously approved these changes Feb 16, 2019
Copy link
Contributor

@blewjy blewjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Working as expected now.

Copy link
Contributor

@leeyh20 leeyh20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, however why are there extra files changed? (VSWorkspaceState and sqlite)
These should be ignored in git.

@ChesterSng
Copy link
Contributor Author

@leeyh20 removed the extra files changed

@leeyh20 leeyh20 merged commit db84561 into PowerPointLabs:dev-release Feb 20, 2019
@ChesterSng ChesterSng changed the title #26 Open SelectionPane after editting name #26 Open SelectionPane after editing name Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants