Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips lab: Create tooltip #1782

Merged
merged 7 commits into from Feb 20, 2019
Merged

Tooltips lab: Create tooltip #1782

merged 7 commits into from Feb 20, 2019

Conversation

blewjy
Copy link
Contributor

@blewjy blewjy commented Feb 14, 2019

On clicking of the Create Tooltip option, 1 of 2 things will occur:

  1. If no prior selection, a default callout and trigger shape will be generated.
  2. If there is a prior selection, a default callout shape will be generated on top of the selection. Multiple selection will generate multiple callout shapes.

Copy link
Contributor

@ChesterSng ChesterSng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @blewjy good job on the PR!

Is it better to group the callout shape and trigger shape after you generate them (when a user does not select anything and use Create Tooltip), this way it is easier for the user to shift the pair around.

@ChesterSng ChesterSng merged commit 292878f into PowerPointLabs:tooltips-lab Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants