Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1814 Remove textbox from callout in TooltipsLab #1819

Merged
merged 2 commits into from Mar 24, 2019
Merged

#1814 Remove textbox from callout in TooltipsLab #1819

merged 2 commits into from Mar 24, 2019

Conversation

blewjy
Copy link
Contributor

@blewjy blewjy commented Mar 19, 2019

Fixes #1814

Previously, there was a textbox added to the generated callout shape from TooltipsLab which may make things complicated for the user. This textbox has been removed in this PR and for any text, user will use the shape's default textbox instead.

@ChesterSng
Copy link
Contributor

ChesterSng commented Mar 19, 2019

@blewjy should we still focus on the textbox of the callout after it is created?

The reason for this is to have a visual cue for the user to input his text directly on the shape.

Another way is to have a default text to the callout shape as well such as "Tooltip"

What do you think, Prof @damithc?

@blewjy
Copy link
Contributor Author

blewjy commented Mar 19, 2019

@ChesterSng Personally I don't think it is necessary to focus on the shape's textbox after the callout is created, because it is possible that the user may want to put other things inside the textbox other than text, for e.g. images.

Nevertheless I did give it a try and when trying to select the TextFrame of the shape, it seems to result in like a space character that is being highlighted for some reason, instead of being just a blinking cursor as expected... Typing immediately will revert it back to normal, i.e. there is no actual space character there.

Actual:

Expected:

@blewjy
Copy link
Contributor Author

blewjy commented Mar 19, 2019

If we want we can also choose to just select the callout shape

@ChesterSng
Copy link
Contributor

The text in the textbox will overflow the callout. I think you should make the callout shape resize when text overflows like in ELL. @blewjy

Prof @damithc, should there be default text in the callout shape like in here:
image

@blewjy
Copy link
Contributor Author

blewjy commented Mar 21, 2019

The text in the textbox will overflow the callout. I think you should make the callout shape resize when text overflows like in ELL.

@ChesterSng good point! Fixed! :)

@damithc
Copy link
Member

damithc commented Mar 21, 2019

Prof @damithc, should there be default text in the callout shape like in here:

No need.

Copy link
Contributor

@ChesterSng ChesterSng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexfjw alexfjw merged commit db84bff into PowerPointLabs:dev-release Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants