New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1825 Add Progress Bar mode to TimerLab #1826
#1825 Add Progress Bar mode to TimerLab #1826
Conversation
- Also added test for when progress bar checkbox is ticked when there is an existing original timer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ChesterSng, great job with this new feature! I think it's a cool feature and a very ingenious way of using the grow/shrink animation here. Working perfectly on PPT2013, including updated FT.
I only have some comments on the code, other than that, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working on PowerPoint 2010. Please extract the reused block of code into a separate function.
Fixes #1825
Outline of Solution
The progress bar is implemented the following way:
Functional Tests are added for Progress Bar: