Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1825 Add Progress Bar mode to TimerLab #1826

Merged

Conversation

ChesterSng
Copy link
Contributor

@ChesterSng ChesterSng commented Mar 21, 2019

Fixes #1825
Outline of Solution

The progress bar is implemented the following way:

  1. Create two bars (each of same height and width of the timer body)
  2. First bar is filled with colour, second bar is transparent.
  3. Concatenate second bar to first bar and group the two bars
  4. Align first bar with the timer body.
  5. Apply Shrink to 0 width animation to the progress bar over set duration.

Functional Tests are added for Progress Bar:

  1. Tests on the original timer lab are tested again when progress bar is enabled
  2. Added test case when there is already a timer on the slide and progress bar is enabled/disabled
  • Implementation of Progress Bar
  • Adding Functional Test Cases for Progress Bar
  • Refactor Code

@ChesterSng ChesterSng closed this Mar 21, 2019
@ChesterSng ChesterSng changed the base branch from master to dev-release March 21, 2019 15:41
@ChesterSng ChesterSng reopened this Mar 21, 2019
@ChesterSng ChesterSng marked this pull request as ready for review March 22, 2019 08:30
Copy link
Contributor

@blewjy blewjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ChesterSng, great job with this new feature! I think it's a cool feature and a very ingenious way of using the grow/shrink animation here. Working perfectly on PPT2013, including updated FT.

I only have some comments on the code, other than that, LGTM!

@blewjy blewjy added the ok-2013 label Mar 22, 2019
Copy link
Contributor

@YuPeiHenry YuPeiHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working on PowerPoint 2010. Please extract the reused block of code into a separate function.

@ChesterSng ChesterSng requested a review from leeyh20 April 4, 2019 09:02
@blewjy blewjy merged commit 3e14d91 into PowerPointLabs:dev-release Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants