New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1867 Adjust similarity tolerance for ZoomToArea test #1870
#1867 Adjust similarity tolerance for ZoomToArea test #1870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test failed for me. There was a 0.89 similarity.
Test Name: FT_ZoomToAreaTest
Test FullName: Test.FunctionalTest.ZoomToAreaTest.FT_ZoomToAreaTest
Test Source: C:\Users\Admin\Desktop\other_repos\Chester PPL\PowerPointLabs\Test\FunctionalTest\ZoomToAreaTest.cs : line 17
Test Outcome: Failed
Test Duration: 0:00:53.321832
Result StackTrace:
at Test.Util.SlideUtil.IsSameLooking(FileInfo expSlideImage, FileInfo actualSlideImage, Double similarityTolerance) in C:\Users\Admin\Desktop\other_repos\Chester PPL\PowerPointLabs\Test\Util\SlideUtil.cs:line 155
at Test.Util.SlideUtil.IsSameLooking(String expSlideImage, String actualSlideImage, Double similarityTolerance) in C:\Users\Admin\Desktop\other_repos\Chester PPL\PowerPointLabs\Test\Util\SlideUtil.cs:line 144
at Test.Util.SlideUtil.IsSameLooking(Slide expSlide, Slide actualSlide, Double similarityTolerance) in C:\Users\Admin\Desktop\other_repos\Chester PPL\PowerPointLabs\Test\Util\SlideUtil.cs:line 139
at Test.FunctionalTest.ZoomToAreaTest.AssertIsSame(Int32 actualSlideIndex, Int32 expectedSlideIndex) in C:\Users\Admin\Desktop\other_repos\Chester PPL\PowerPointLabs\Test\FunctionalTest\ZoomToAreaTest.cs:line 107
at Test.FunctionalTest.ZoomToAreaTest.AssertAreSame(Int32 actualStartSlideIndex, Int32 expectedStartSlideIndex, Int32 slideCount) in C:\Users\Admin\Desktop\other_repos\Chester PPL\PowerPointLabs\Test\FunctionalTest\ZoomToAreaTest.cs:line 98
at Test.FunctionalTest.ZoomToAreaTest.TestMultipleZoomConfig3() in C:\Users\Admin\Desktop\other_repos\Chester PPL\PowerPointLabs\Test\FunctionalTest\ZoomToAreaTest.cs:line 47
at Test.FunctionalTest.ZoomToAreaTest.FT_ZoomToAreaTest() in C:\Users\Admin\Desktop\other_repos\Chester PPL\PowerPointLabs\Test\FunctionalTest\ZoomToAreaTest.cs:line 21
Result Message: Assert.IsTrue failed. The slides look different. Similarity = 0.893939393939394
Tests passed on PPT2016. Code LGTM! |
is it due to different resolutions on different machines? |
@leeyh20 unlikely to be because of resolution, because i adjusted the scaling on the same machine and it gives the same results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test is passing for me on PPT2013
Test is passing on PPT 2010 and 2016. |
Fixes #1867
0.95
to0.89
to account for the slight difference in slides generated byZoomToArea
on different machines when there are multiple shapes to zoom into.