Add --input and --input-file to dsc
#217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Non-blocking, but we may want to have a think about the UX for global options—currently, if I want to use both the format and input options, I have to run a command like: dsc -f pretty-json -i $desired resource test -r Example.Go/TSToyThis isn't very ergonomic, esp since these options are provided before two layers of subcommands. From my perspective, this would be the more natural command: dsc resource test -f pretty-json -r Example.Go/TSToy -i $desiredIs it possible to define option flags on the subcommands that override/define the globals for convenience? I haven't delved too deeply into clap, but in cobra you can define persistent options that work this way (define once, available on all child commands). |
|
@michaeltlombardi let's cover that topic as part of the cmdline review meeting |
miroman9364
approved these changes
Oct 4, 2023
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Oct 5, 2023
This change updates the project changelog, reference documentation, and schemas for the recent PRs merged for the project: - PowerShell#206 - PowerShell#208 - PowerShell#211 - PowerShell#213 - PowerShell#215 - PowerShell#216 - PowerShell#217 The updates include: - Documenting the new `_exist` property, replacing `_ensure` for resources. This documentation update includes the schema definition, but doesn't regenerate the schema, which will be handled separately. - Documenting the new `completer` command. - Documenting the new `--input` and `--input-file` global options. - Adding a deprecation notice to the `_ensure` documentation. - Adding entries for all user-impacting changes to the changelog.
This was referenced Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add
-i | --inputand-p | --input-fileas ways to pass input todscinstead of just via stdin. The two parameters are mutually exclusive. Currently, stdin is ignored if either of these parameters are used.PR Context
Fix #130