Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes PowerShell/DSC#159 resources should have enum labels #208

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

miroman9364
Copy link
Contributor

@miroman9364 miroman9364 commented Sep 27, 2023

This fixes #159. When converting JSON into PowerShell object, replace enum values with the string label names.

This fixes issue PowerShell#159. When converting JSON into PowerShell object,
replace enum values with the string label names.
@SteveL-MSFT
Copy link
Member

@miroman9364 update your PR description to use one of the supported GitHub syntax for referencing an issue so that it closes it automatically upon merge: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@miroman9364 miroman9364 changed the title Fix resources should have enum labels Fixes PowerShell/DSC#159 resources should have enum labels Sep 27, 2023
@miroman9364 miroman9364 changed the title Fixes PowerShell/DSC#159 resources should have enum labels Fixes #159 resources should have enum labels Sep 27, 2023
@miroman9364 miroman9364 changed the title Fixes #159 resources should have enum labels Fixes PowerShell/DSC#159 resources should have enum labels Sep 27, 2023
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue Sep 28, 2023
Merged via the queue into PowerShell:main with commit ac8bc2f Sep 28, 2023
4 checks passed
@miroman9364 miroman9364 deleted the miroman/wi159 branch September 28, 2023 16:54
michaeltlombardi added a commit to michaeltlombardi/DSC that referenced this pull request Oct 5, 2023
This change updates the project changelog, reference documentation, and
schemas for the recent PRs merged for the project:

- PowerShell#206
- PowerShell#208
- PowerShell#211
- PowerShell#213
- PowerShell#215
- PowerShell#216
- PowerShell#217

The updates include:

- Documenting the new `_exist` property, replacing `_ensure` for
  resources. This documentation update includes the schema definition,
  but doesn't regenerate the schema, which will be handled separately.
- Documenting the new `completer` command.
- Documenting the new `--input` and `--input-file` global options.
- Adding a deprecation notice to the `_ensure` documentation.
- Adding entries for all user-impacting changes to the changelog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PSDSC resources should have enum labels, not values in results JSON
2 participants