Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Bug in Wiki Generation when Used without Harness #245

Closed
PlagueHO opened this issue Jul 7, 2018 · 2 comments
Closed

Bug in Wiki Generation when Used without Harness #245

PlagueHO opened this issue Jul 7, 2018 · 2 comments
Labels
bug The issue is a bug.

Comments

@PlagueHO
Copy link
Collaborator

PlagueHO commented Jul 7, 2018

There is a bug in the Wiki generation code in Invoke-AppveyorAfterTestTask. One of the variables was incorrect and the value was being picked up from the AppVeyor.yml file definition instead of being passed in as a parameter.

See: https://ci.appveyor.com/project/PlagueHO/wsmandsc#L989
@PlagueHO
Copy link
Collaborator Author

PlagueHO commented Jul 7, 2018

This bug will affect any Wiki generation module where the variable $mainModuleFolder is defined in AppVeyor.yml (@ykuijs). If you remove the variable $mainModuleFolder from AppVeyor.yml then this bug is exposed. So fixing this bug will allow the $mainModuleFolder to be removed from AppVeyor.yml.

johlju pushed a commit that referenced this issue Jul 7, 2018
@PlagueHO @johlju
Fix Wiki Generation Bug using Out of Scope Variable (#246)
ff6c71e 
- Fix bug in `Invoke-AppveyorAfterTestTask` to prevent Wiki generation function
  from getting documentation files from variable `$MainModulePath` defined in
  AppVeyor.yml (issue #245)
@johlju
Copy link
Contributor

johlju commented Jul 7, 2018

Resolved by PR #246

@johlju johlju closed this as completed Jul 7, 2018
@johlju johlju added the bug The issue is a bug. label Jul 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug The issue is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johlju @PlagueHO