This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Fix Wiki Generation Bug using Out of Scope Variable - Fixes #245 #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #246 +/- ##
===================================
Coverage 56% 56%
===================================
Files 12 12
Lines 1467 1467
===================================
Hits 835 835
Misses 632 632 |
|
@johlju - would you mind reviewing and merging this one? It will allow me to continue to convert all my harness modules out of being harness (one step closer to "no more harnesses" 😁) |
johlju
approved these changes
Jul 7, 2018
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the
$mainModuleFoldervariable is used from the parent scope (AppVeyor.yml usually).This change is