This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Remove default values of ExcludeTag parameter in favor of opt-in #274
Labels
enhancement
The issue is an enhancement request.
Since the parameter
ExcludeTag
on the functionInvoke-AppveyorTestScriptTask
is not intuitive.I wonder if we can make it obsolete, or rather remove the default values, by using opt-in.
It defaults to 'Examples' and 'Markdown'.
DscResource.Tests/AppVeyor.psm1
Line 164 in 60efdea
They are meant to exclude the meta tests (common tests) for examples and markdown.
DscResource.Tests/AppVeyor.psm1
Lines 231 to 236 in 60efdea
But the tests with markdown has already an opt-in.
DscResource.Tests/Meta.Tests.ps1
Lines 849 to 850 in 60efdea
Same with the example tests.
DscResource.Tests/Meta.Tests.ps1
Lines 582 to 583 in 60efdea
DscResource.Tests/Meta.Tests.ps1
Lines 761 to 762 in 60efdea
So I think it is safe to remove the default values from this parameter, since all those thests must be opt-in by op-tin in the file .MetaTestOptIn.json.
DscResource.Tests/.MetaTestOptIn.json
Lines 1 to 6 in 60efdea
The text was updated successfully, but these errors were encountered: