Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Removed the default values of the parameter ExcludeTag in favor of using opt-in #277

Merged
merged 5 commits into from
Aug 11, 2018

Conversation

johlju
Copy link
Contributor

@johlju johlju commented Aug 8, 2018

Fixes #274


This change is Reviewable

@johlju johlju changed the title Removed the default values of the parameter ExcludeTag in favor of using opt-in. Removed the default values of the parameter ExcludeTag in favor of using opt-in Aug 8, 2018
@review-me review-me bot added the needs review The pull request needs a code review. label Aug 8, 2018
@codecov-io
Copy link

codecov-io commented Aug 8, 2018

Codecov Report

Merging #277 into dev will decrease coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #277   +/-   ##
===================================
- Coverage    72%    72%   -1%     
===================================
  Files        12     12           
  Lines      1523   1522    -1     
  Branches      2      2           
===================================
- Hits       1109   1108    -1     
  Misses      412    412           
  Partials      2      2

@review-me review-me bot removed the needs review The pull request needs a code review. label Aug 8, 2018
@johlju
Copy link
Contributor Author

johlju commented Aug 8, 2018

Tested OK here:

CertificateDsc (using -ExcludeTag @()): https://ci.appveyor.com/project/johlju/certificatedsc/build/2.3.27.0
PSDscResource (not using ExcludeTag): https://ci.appveyor.com/project/johlju/psdscresources/build/2.4.98.0#L1270

@review-me review-me bot added the needs review The pull request needs a code review. label Aug 8, 2018
@review-me review-me bot added needs review The pull request needs a code review. and removed needs review The pull request needs a code review. labels Aug 8, 2018
Copy link
Collaborator

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff @johlju - :lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: 1 of 4 files reviewed, all discussions resolved (waiting on @PlagueHO)

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels Aug 11, 2018
@johlju johlju merged commit 6b03803 into PowerShell:dev Aug 11, 2018
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Aug 11, 2018
@johlju johlju deleted the remove-excludetag-default-values branch August 11, 2018 08:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants