Use stringbuilder as buffer

PowerShell · Jan 14, 2024 · 6de7df1 · 6de7df1
1 parent c7f5329
commit 6de7df1
Showing 1 changed file with 3 additions and 19 deletions.
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/ShowMarkdownCommand.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/ShowMarkdownCommand.cs
@@ -62,8 +62,6 @@ public string[] LiteralPath
 
         private System.Management.Automation.PowerShell _powerShell;
 
-        private PSMarkdownOptionInfo _mdOption;
-
         private readonly StringBuilder _inputObjectBuffer = new();
 
         /// <summary>
@@ -72,7 +70,6 @@ public string[] LiteralPath
         protected override void BeginProcessing()
         {
             _powerShell = System.Management.Automation.PowerShell.Create(RunspaceMode.CurrentRunspace);
-            _mdOption = PSMarkdownOptionInfoCache.Get(CommandInfo);
         }
 
         /// <summary>
@@ -85,19 +82,15 @@ protected override void ProcessRecord()
                 case "InputObject":
                     if (InputObject.BaseObject is MarkdownInfo markdownInfo)
                     {
-                        string markdownInfoString = UseBrowser.IsPresent
-                            ? markdownInfo.Html
-                            : markdownInfo.VT100EncodedString;
-
-                        _inputObjectBuffer.AppendLine(markdownInfoString);
+                        ProcessMarkdownInfo(markdownInfo);
                     }
                     else if (InputObject.BaseObject is string objectString)
                     {
                         _inputObjectBuffer.AppendLine(objectString);
                     }
                     else
                     {
-                        _inputObjectBuffer.AppendLine(InputObject.BaseObject.ToString());
+                        ConvertFromMarkdown("InputObject", InputObject.BaseObject);
                     }
 
                     break;
@@ -240,16 +233,7 @@ protected override void EndProcessing()
         {
             if (_inputObjectBuffer.Length > 0)
             {
-                MarkdownConversionType conversionType = UseBrowser.IsPresent 
-                    ? MarkdownConversionType.HTML 
-                    : MarkdownConversionType.VT100;
-
-                MarkdownInfo convertedMarkdownInfo = MarkdownConverter.Convert(
-                    _inputObjectBuffer.ToString(), 
-                    conversionType, 
-                    _mdOption);
-
-                ProcessMarkdownInfo(convertedMarkdownInfo);
+                ConvertFromMarkdown(ParameterSetName, _inputObjectBuffer.ToString());
             }
 
             _powerShell?.Dispose();