Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CA1309: Use ordinal string comparison #15669

Closed
xtqqczze opened this issue Jun 25, 2021 · 5 comments
Closed

Fix CA1309: Use ordinal string comparison #15669

xtqqczze opened this issue Jun 25, 2021 · 5 comments
Labels
Issue-Code Cleanup the issue is for cleaning up the code with no impact on functionality Needs-Triage The issue is new and needs to be triaged by a work group. Resolution-No Activity Issue has had no activity for 6 months or more

Comments

@xtqqczze
Copy link
Contributor

xtqqczze commented Jun 25, 2021 •
edited

Tracking issue.

CA1309: Use ordinal string comparison
@xtqqczze xtqqczze added Issue-Enhancement the issue is more of a feature request than a bug Needs-Triage The issue is new and needs to be triaged by a work group. labels Jun 25, 2021
@xtqqczze
Copy link
Contributor Author 

X:\src\System.Management.Automation\engine\GetCommandCommand.cs(594,97): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\GetCommandCommand.cs(601,86): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\GetCommandCommand.cs(625,39): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\Modules\ModuleSpecification.cs(329,27): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\DscSupport\CimDSCParser.cs(1894,48): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\Modules\ModuleCmdletBase.cs(1269,36): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\Modules\ImportModuleCommand.cs(1934,66): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\Modules\ModuleCmdletBase.cs(4042,30): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\Modules\ModuleCmdletBase.cs(1715,40): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\commands\InvokeCommandCommand.cs(863,46): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\commands\InvokeCommandCommand.cs(864,34): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\commands\InvokeCommandCommand.cs(926,34): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\commands\InvokeCommandCommand.cs(985,34): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\commands\InvokeCommandCommand.cs(1078,39): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\commands\InvokeCommandCommand.cs(1158,39): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\commands\InvokeCommandCommand.cs(1163,43): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\commands\InvokeCommandCommand.cs(1194,38): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\commands\InvokeCommandCommand.cs(1249,64): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\commands\InvokeCommandCommand.cs(1259,57): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\commands\InvokeCommandCommand.cs(1324,35): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\commands\InvokeCommandCommand.cs(1394,34): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\commands\InvokeCommandCommand.cs(1942,34): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\commands\InvokeCommandCommand.cs(1950,38): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\commands\InvokeCommandCommand.cs(1951,38): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\commands\InvokeCommandCommand.cs(1958,43): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\commands\InvokeCommandCommand.cs(1959,43): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\commands\InvokeCommandCommand.cs(1966,43): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\commands\InvokeCommandCommand.cs(1967,43): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\commands\PSRemotingCmdlet.cs(3026,83): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\commands\PSRemotingCmdlet.cs(3084,83): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\cimSupport\cmdletization\ScriptWriter.cs(343,43): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\help\HelpCommands.cs(435,53): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]   
X:\src\System.Management.Automation\help\HelpCommands.cs(436,53): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]   
X:\src\System.Management.Automation\cimSupport\cmdletization\ScriptWriter.cs(1737,50): error 
CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\CommandCompletion\CommandCompletion.cs(989,79): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\CommandCompletion\CommandCompletion.cs(1131,59): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\FormatAndOutput\common\FormatGroupManager.cs(100,61): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\CoreAdapter.cs(4771,35): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj] 
X:\src\System.Management.Automation\engine\CoreAdapter.cs(3378,37): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj] 
X:\src\System.Management.Automation\engine\CoreAdapter.cs(4260,52): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj] 
X:\src\System.Management.Automation\engine\CoreAdapter.cs(4261,52): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj] 
X:\src\System.Management.Automation\engine\CoreAdapter.cs(4262,52): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj] 
X:\src\System.Management.Automation\engine\CommandCompletion\CompletionCompleters.cs(7268,53): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\EnumExpressionEvaluator.cs(500,24): error CA1309: 
Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\EnumExpressionEvaluator.cs(504,29): error CA1309: 
Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\EnumExpressionEvaluator.cs(508,29): error CA1309: 
Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\hostifaces\MshHostUserInterface.cs(1310,74): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\hostifaces\MshHostUserInterface.cs(1325,82): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\hostifaces\Connection.cs(1733,22): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\TypeTable.cs(150,67): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]    
X:\src\System.Management.Automation\engine\TypeTable.cs(154,92): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]    
X:\src\System.Management.Automation\engine\remoting\common\RunspaceConnectionInfo.cs(1296,38): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\InitialSessionState.cs(3443,59): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\runtime\CompiledScriptBlock.cs(1146,42): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\runtime\CompiledScriptBlock.cs(1146,73): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\runtime\CompiledScriptBlock.cs(1146,101): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\Modules\ModuleIntrinsics.cs(803,31): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\Modules\ModuleIntrinsics.cs(804,31): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\MshObject.cs(507,50): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]    
X:\src\System.Management.Automation\engine\parser\TypeInferenceVisitor.cs(116,27): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\client\JobManager.cs(144,102): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\client\remoterunspace.cs(2614,30): error 
CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\client\remoterunspace.cs(1593,36): error 
CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\client\remoterunspace.cs(1598,41): error 
CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\remoting\client\ThrottlingJob.cs(1103,89): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\security\CatalogHelper.cs(712,41): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\VariableInterfaces.cs(75,38): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\engine\TypeMetadata.cs(802,82): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj] 
X:\src\System.Management.Automation\engine\TypeMetadata.cs(807,47): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj] 
X:\src\System.Management.Automation\namespaces\ProviderBase.cs(155,131): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\namespaces\ProviderBase.cs(158,92): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\help\UpdatableHelpSystem.cs(1622,42): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]
X:\src\System.Management.Automation\help\MamlNode.cs(657,52): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]       
X:\src\System.Management.Automation\help\MamlNode.cs(761,54): error CA1309: Use ordinal string comparison [X:\src\System.Management.Automation\System.Management.Automation.csproj]

@xtqqczze xtqqczze mentioned this issue Jun 25, 2021
Merged
@iSazonov iSazonov added Issue-Code Cleanup the issue is for cleaning up the code with no impact on functionality and removed Issue-Enhancement the issue is more of a feature request than a bug labels Jun 25, 2021
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.

2 similar comments
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.

@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.

@microsoft-github-policy-service microsoft-github-policy-service bot added Resolution-No Activity Issue has had no activity for 6 months or more labels Nov 16, 2023
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

This issue has been marked as "No Activity" as there has been no activity for 6 months. It has been closed for housekeeping purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Code Cleanup the issue is for cleaning up the code with no impact on functionality Needs-Triage The issue is new and needs to be triaged by a work group. Resolution-No Activity Issue has had no activity for 6 months or more
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iSazonov @xtqqczze