Skip to content

Fix CA1309: Use ordinal StringComparison in CertificateProvider #14352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2021
Merged

Fix CA1309: Use ordinal StringComparison in CertificateProvider #14352

merged 2 commits into from
Jun 25, 2021

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Dec 8, 2020

Non-breaking change, just makes existing behaviour explicit.

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1309

@ghost ghost assigned iSazonov Dec 8, 2020
@iSazonov iSazonov assigned TravisEz13 and unassigned iSazonov Dec 9, 2020
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 9, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 18, 2020
@ghost
Copy link

ghost commented Dec 18, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze xtqqczze closed this Jun 23, 2021
@xtqqczze xtqqczze reopened this Jun 23, 2021
@xtqqczze xtqqczze closed this Jun 23, 2021
@xtqqczze xtqqczze reopened this Jun 23, 2021
@iSazonov iSazonov requested review from PaulHigin and TravisEz13 June 24, 2021 03:21
PaulHigin
PaulHigin approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the documentation, the default string compare is ordinal. But I think it makes sense to explicitly set the Comparer to make intention clear.

@xtqqczze xtqqczze closed this Jun 24, 2021
@xtqqczze xtqqczze reopened this Jun 24, 2021
@iSazonov iSazonov merged commit a3366b8 into PowerShell:master Jun 25, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 25, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.8 milestone Jun 25, 2021
@xtqqczze xtqqczze deleted the CA1309-p1 branch June 25, 2021 12:22
@xtqqczze
Copy link
Contributor Author

Contributes to #15669.

@ghost
Copy link

ghost commented Jul 22, 2021

🎉v7.2.0-preview.8 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iSazonov iSazonov iSazonov approved these changes

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

+2 more reviewers

@PaulHigin PaulHigin PaulHigin approved these changes

@vexx32 vexx32 vexx32 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@TravisEz13 TravisEz13

Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Milestone
7.2.0-preview.8
Development

Successfully merging this pull request may close these issues.
5 participants
@xtqqczze @PaulHigin @iSazonov @vexx32 @TravisEz13