PSObject wrapped ScriptBlocks should also throw when attempting $using: access

[SeeminglyScience]

The check in ForEach-Object -Parallel for ScriptBlocks in $using: values currently doesn't check PSObjects. This was discovered in #17150

This if:

PowerShell/src/System.Management.Automation/engine/InternalCommands.cs

Lines 422 to 431 in 7cc9c87

	if (item is ScriptBlock)
	{
	ThrowTerminatingError(
	new ErrorRecord(
	new PSArgumentException(InternalCommandStrings.ParallelUsingVariableCannotBeScriptBlock),
	"ParallelUsingVariableCannotBeScriptBlock",
	ErrorCategory.InvalidType,
	this));
	}
	}

Might need to be:

if (item is ScriptBlock or PSObject { BaseObject: ScriptBlock })
{
    // etc
}

Steps to reproduce

$sb = { 'worked' }
0 | ForEach-Object -Parallel { & $using:sb }

$sb = [psobject]{ 'worked' }
0 | ForEach-Object -Parallel { & $using:sb }

Expected behavior

ForEach-Object:
Line |
   2 |  0 | ForEach-Object -Parallel { & $using:sb }
     |      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | A ForEach-Object -Parallel using variable cannot be a script block. Passed-in script block variables are not supported with ForEach-Object -Parallel, and can result in undefined behavior.

ForEach-Object:
Line |
   5 |  0 | ForEach-Object -Parallel { & $using:sb }
     |      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | A ForEach-Object -Parallel using variable cannot be a script block. Passed-in script block variables are not supported with ForEach-Object -Parallel, and can result in undefined behavior.

Actual behavior

ForEach-Object:
Line |
   2 |  0 | ForEach-Object -Parallel { & $using:sb }
     |      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | A ForEach-Object -Parallel using variable cannot be a script block. Passed-in script block variables are not supported with ForEach-Object -Parallel, and can result in undefined behavior.
worked

Environment data

Name                           Value
----                           -----
PSVersion                      7.3.0-preview.3
PSEdition                      Core
GitCommitId                    7.3.0-preview.3
OS                             Microsoft Windows 10.0.19044
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

[ryneandal]

If this is up for grabs, I would love to take a crack at it, if that's alright.

[SeeminglyScience]

@ryneandal Absolutely! If you have any questions feel free to ask 🙂

[ryneandal]

Awesome, thanks. Per the contribution guidelines, could I get an assignment from @powershell/powershell?

[ghost]

🎉This issue was addressed in #17234, which has now been successfully released as v7.3.0-preview.4.:tada:

Handy links:

• Release Notes