Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Coverage Status Badge is cached #3122

Closed
iSazonov opened this issue Feb 9, 2017 · 6 comments · Fixed by #4121
Closed

Code Coverage Status Badge is cached #3122

iSazonov opened this issue Feb 9, 2017 · 6 comments · Fixed by #4121
Assignees
Labels
WG-Quality-Test issues in a test or in test infrastructure
Projects
Milestone

Comments

@iSazonov
Copy link
Collaborator

iSazonov commented Feb 9, 2017

Our main ReadMe.md contains Code Coverage Status. The badge looks wrongly due to caching (the badge display old information).

Fix from github/markup#224

We're pretty confident that the image caching works. If you're having issues with something like a CI badge, make sure the image has the Cache-Control: no-cache header, and either Expires , Last-Modified or Etag .

Or workaround from https://github.com/codecov/support/issues/218

[![Coverage](
https://img.shields.io/codecov/c/github/chesslave/chesslave.svg?maxAge=600)]
(https://codecov.io/gh/chesslave/chesslave)

URL param  maxAge  does the trick. The value is expressed in seconds.
@SteveL-MSFT SteveL-MSFT added the WG-Quality-Test issues in a test or in test infrastructure label Feb 11, 2017
@adityapatwardhan
Copy link
Member

adityapatwardhan commented Feb 13, 2017

@iSazonov The badge seems to showing the latest build. Are you seeing it otherwise?

@iSazonov
Copy link
Collaborator Author

Today I see 33% and on the coveralls.io I see the same.
In recent days I have seen sometimes old up to 4-day badge.

@iSazonov
Copy link
Collaborator Author

Check from another computer - 46% vs 46%. No problem.

@adityapatwardhan
Copy link
Member

@iSazonov So are you OK closing the issue?

@iSazonov
Copy link
Collaborator Author

Yes. We can always come back if the problem appears.

@iSazonov
Copy link
Collaborator Author

@adityapatwardhan The Issue is up. I see 21% - really 49%.

@SteveL-MSFT SteveL-MSFT reopened this Jun 22, 2017
@SteveL-MSFT SteveL-MSFT added this to the 6.0.0-HighPriority milestone Jun 22, 2017
adityapatwardhan added a commit to adityapatwardhan/PowerShell that referenced this issue Jun 27, 2017
* The code coverage badge it updated to point to codecov.io
* Added filter to ignore PSReadline code coverage.

This fixes PowerShell#3122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WG-Quality-Test issues in a test or in test infrastructure
Projects
Testability
  
Awaiting triage
Development

Successfully merging a pull request may close this issue.

3 participants