Remove FullCLR code #4357

SteveL-MSFT · 2017-07-27T04:59:26Z

This project started as a fork of the Windows PowerShell 5.1 code base. As we've progressed towards a PowerShell Core 6.0 release and with the capability of dotnet core 2.0 and dotnet std 2.0 being able to load dotnet framework 4.5.1+ assemblies that are compatible with dotnet std 2.0, we can simplify the code base by removing the legacy FullCLR code so that we no longer have #ifdefs for CORECLR (and !CORECLR). This was discussed and approved by @PowerShell/powershell-committee. When reviewing the code, do not blindly just remove the FullCLR code, but validate if updates to .NET Core means using the FullCLR code instead of the limited .NET Core code.

Remaining `#if [!]CORECLR` usages

param($path = "../repos/PowerShell")

$sources = Get-ChildItem -Recurse -Path $path -Include *.cs
foreach ($source in $sources) {
    $content = Get-Content $source -Raw
    if ($content -match "#if CORECLR" -or $content -match "#if !CORECLR") {
        $source.FullName
    }
}

src/Microsoft.PowerShell.Commands.Diagnostics/CoreCLR/Stubs.cs
src/Microsoft.PowerShell.Commands.Diagnostics/CommonUtils.cs
src/Microsoft.PowerShell.Commands.Diagnostics/ExportCounterCommand.cs
src/Microsoft.PowerShell.Commands.Diagnostics/GetCounterCommand.cs
src/Microsoft.PowerShell.Commands.Diagnostics/ImportCounterCommand.cs
src/Microsoft.PowerShell.Commands.Diagnostics/NewWinEventCommand.cs
src/Microsoft.PowerShell.Commands.Utility/commands/utility/new-object.cs
src/Microsoft.PowerShell.LocalAccounts/LocalAccounts/Extensions.cs
src/Microsoft.PowerShell.LocalAccounts/LocalAccounts/Sam.cs
src/Microsoft.PowerShell.Security/security/AclCommands.cs
src/Microsoft.PowerShell.Security/security/CertificateProvider.cs
src/Microsoft.PowerShell.Security/security/ExecutionPolicyCommands.cs
src/Microsoft.WSMan.Management/CredSSP.cs
src/Microsoft.WSMan.Management/Interop.cs
src/Microsoft.WSMan.Management/WsManHelper.cs
src/System.Management.Automation/cimSupport/cmdletization/xml/CoreCLR/cmdlets-over-objects.xmlSerializer.autogen.cs
src/System.Management.Automation/cimSupport/cmdletization/ScriptWriter.cs
src/System.Management.Automation/CoreCLR/CorePsAssemblyLoadContext.cs
src/System.Management.Automation/DscSupport/CimDSCParser.cs
src/System.Management.Automation/engine/debugger/debugger.cs
src/System.Management.Automation/engine/hostifaces/Command.cs
src/System.Management.Automation/engine/hostifaces/Connection.cs
src/System.Management.Automation/engine/hostifaces/ConnectionBase.cs
src/System.Management.Automation/engine/hostifaces/HostUtilities.cs
src/System.Management.Automation/engine/hostifaces/InternalHost.cs
src/System.Management.Automation/engine/hostifaces/LocalConnection.cs
src/System.Management.Automation/engine/hostifaces/LocalPipeline.cs
src/System.Management.Automation/engine/hostifaces/Parameter.cs
src/System.Management.Automation/engine/hostifaces/PowerShell.cs
src/System.Management.Automation/engine/hostifaces/PowerShellProcessInstance.cs
src/System.Management.Automation/engine/hostifaces/RunspacePool.cs
src/System.Management.Automation/engine/hostifaces/RunspacePoolInternal.cs
src/System.Management.Automation/engine/interpreter/ControlFlowInstructions.cs
src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs
src/System.Management.Automation/engine/parser/Compiler.cs
src/System.Management.Automation/engine/parser/FusionAssemblyIdentity.cs
src/System.Management.Automation/engine/parser/GlobalAssemblyCache.cs
src/System.Management.Automation/engine/parser/Parser.cs
src/System.Management.Automation/engine/parser/TypeResolver.cs
src/System.Management.Automation/engine/remoting/client/remoterunspace.cs
src/System.Management.Automation/engine/remoting/commands/CustomShellCommands.cs
src/System.Management.Automation/engine/remoting/commands/EnterPSHostProcessCommand.cs
src/System.Management.Automation/engine/remoting/commands/remotingcommandutil.cs
src/System.Management.Automation/engine/remoting/commands/ResumeJob.cs
src/System.Management.Automation/engine/remoting/commands/SuspendJob.cs
src/System.Management.Automation/engine/remoting/common/WireDataFormat/EncodeAndDecode.cs
src/System.Management.Automation/engine/remoting/common/RemoteSessionNamedPipe.cs
src/System.Management.Automation/engine/remoting/common/RunspaceConnectionInfo.cs
src/System.Management.Automation/engine/remoting/common/throttlemanager.cs
src/System.Management.Automation/engine/remoting/fanin/BaseTransportManager.cs
src/System.Management.Automation/engine/remoting/fanin/InitialSessionStateProvider.cs
src/System.Management.Automation/engine/remoting/fanin/WSManPlugin.cs
src/System.Management.Automation/engine/remoting/fanin/WSManPluginFacade.cs
src/System.Management.Automation/engine/remoting/fanin/WSManTransportManager.cs
src/System.Management.Automation/engine/remoting/server/OutOfProcServerMediator.cs
src/System.Management.Automation/engine/remoting/server/ServerPowerShellDriver.cs
src/System.Management.Automation/engine/remoting/server/serverremotesession.cs
src/System.Management.Automation/engine/remoting/server/ServerRunspacePoolDriver.cs
src/System.Management.Automation/engine/remoting/server/ServerSteppablePipelineDriver.cs
src/System.Management.Automation/engine/Attributes.cs
src/System.Management.Automation/engine/CommandDiscovery.cs
src/System.Management.Automation/engine/CommandMetadata.cs
src/System.Management.Automation/engine/ExecutionContext.cs
src/System.Management.Automation/engine/GetEvent_Types_Ps1Xml.cs
src/System.Management.Automation/engine/InitialSessionState.cs
src/System.Management.Automation/engine/LanguagePrimitives.cs
src/System.Management.Automation/engine/MshCommandRuntime.cs
src/System.Management.Automation/engine/pipeline.cs
src/System.Management.Automation/engine/serialization.cs
src/System.Management.Automation/engine/Types_Ps1Xml.cs
src/System.Management.Automation/engine/Utils.cs
src/System.Management.Automation/help/HelpSystem.cs
src/System.Management.Automation/help/UpdatableHelpCommandBase.cs
src/System.Management.Automation/help/UpdatableHelpSystem.cs
src/System.Management.Automation/help/UpdateHelpCommand.cs
src/System.Management.Automation/logging/MshLog.cs
src/System.Management.Automation/namespaces/FileSystemProvider.cs
src/System.Management.Automation/namespaces/RegistryProvider.cs
src/System.Management.Automation/namespaces/Win32Native.cs
src/System.Management.Automation/security/SecureStringHelper.cs
src/System.Management.Automation/singleshell/config/MshSnapinInfo.cs
src/System.Management.Automation/utils/ClrFacade.cs
src/System.Management.Automation/utils/StructuredTraceSource.cs

The text was updated successfully, but these errors were encountered:

iSazonov · 2017-07-27T06:57:15Z

Could we save the code history in a reference branch? It can help with backward compatibility issues.

iSazonov · 2017-07-27T06:59:06Z

What is a plan - one PR from MSFT or multiple PRs from community too?

Search results for #if .*CORECLR - 543 results in 186 files.

Related. From #2969 @daxian-dbw:

We need to clean up ApartmentState related workarounds in powershell now.

Search results for ApartmentState 389 results in 52 files

iSazonov · 2017-07-27T13:55:33Z

I found #if V2 in src\System.Management.Automation\minishell\api\RunspaceConfiguration.cs 😕

iSazonov · 2017-07-27T15:01:33Z

#3565 is related. I reviewed CORECLR (and !CORECLR) - most of these relate with moving to .Net 2.0 - assembly load, ApartmentState/STA, unimplemented classes/methods/properties in .Net 1.0 and so on. Sometimes it's hard to distinguish. So it's probably easier to clean up the file by file.

daxian-dbw · 2017-07-27T16:34:35Z

What is a plan - one PR from MSFT or multiple PRs from community too?

The work should be split to multiple PRs for sure, for example, the AprtmentState related changes should be one PR.
I think this work needs to be done by people who are very familiar with the code base because it's not a simple code removal work -- some code blocks with #if !CORECLR might need to enabled because the missing types are back in .NET Core 2.0; some code blocks might need to be kept because the desired functionality was disabled in powershell core because the code needs to be somehow adjusted or rewritten.

SteveL-MSFT · 2017-07-27T16:48:07Z

Agree that we should divide up this work as multiple PRs from multiple people. Since we're formally deprecated v2, we should clean up that code as well.

iSazonov · 2017-07-27T18:20:45Z

Thanks for clarify!

I am trying to clean up ClrFacade.cs and see all mentioned cases. I can fix simple cases but leave AprtmentState and assemblies to you :-) - I believe the full cleanup require a huge work and I save your time if make obvious cleanups?

SteveL-MSFT · 2017-07-27T18:38:03Z

As I'm making other changes, I'm removing legacy code if I see it.

daxian-dbw · 2017-07-27T18:58:49Z

@iSazonov yes, please make obvious cleanups as you see them. But please try to keep each PR small so that we don't miss anything in the code review :)

daxian-dbw · 2017-07-28T16:07:35Z

@SteveL-MSFT cmdlets like Enable-PSRemoting and Disable-PSRemoting contain a lot of scripts that deal with Windows PowerShell, shall we also clean up those scripts?

SteveL-MSFT · 2017-07-28T20:28:52Z

@daxian-dbw yes

SteveL-MSFT · 2017-07-28T20:30:27Z

Note that if there is a module that we would eventually split out and publish separately on PSGallery. That module should support Windows PowerShell (in general) and would retain FullCLR code (don't know if they have specific code paths, but Archive and ODataUtils would be examples)

SteveL-MSFT · 2017-08-31T20:55:23Z

We should continue to clean up the code, but it's not a blocker for 6.0.0 release

rjmholt · 2018-04-03T02:18:04Z

EDIT: Moved the list into the top-level issue description at the request of @daxian-dbw.

[big list used to be here]

iSazonov · 2018-04-03T04:20:59Z

@rjmholt Great work!
Could you please move your post in new Meta-Issue and add link here?
Can MSFT team prioritize?

bergmeister · 2018-08-05T16:33:04Z

Note: The CustomPSSnapin class is not even available therefore Snapins are probably not even achievable for FullCLR with the open source code given by this repo. I do not think this is an issue since no one likes/wants Snapin any more due to modules being a better choice. Therefore the better solution could be to completely remove PSSnapin related code.

iSazonov · 2018-08-09T09:54:07Z

It is not difficult until the code is used in serialization.

iSazonov · 2018-11-15T12:08:50Z

@SteveL-MSFT Could you please update a status of the Issue? Seems most was fixed and now it is not clear that we can fix yet.

SteveL-MSFT · 2018-11-20T17:49:24Z

@iSazonov I made an attempt to see what in the check list is already fixed and what isn't. The problem is that the hyperlinks go to older commits and don't reflect current state. Might be easier to write a script to scan the code and generate a new checklist but we won't know what has been fixed, just what needs to be fixed.

iSazonov · 2018-11-21T05:00:08Z

I caught the same and thought that you have an idea - good point about script. We could review "file by file".

SteveL-MSFT · 2018-11-21T06:31:56Z

One thing we should be careful of is not straight removing the FullClr code, but seeing if the Windows PowerShell code now works because of updates to .NET Core.

iSazonov · 2018-11-26T04:56:13Z

@SteveL-MSFT Seems we can close the Issue: all #if FullCLR code was removed (I found FullCLR only in comments) and we have #3565 to track updates of .NET Core.

Update: I found still up to 100 '#if !CORECLR' (like appdomain, apartment) so maybe not close the PR.

iSazonov · 2019-07-12T14:51:49Z

Search results for #if .*CORECLR - 543 results in 186 files.

Now search results for #if .*CORECLR - 174 results in 70 files.

microsoft-github-policy-service · 2023-11-16T09:18:31Z

This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.

microsoft-github-policy-service · 2023-11-16T09:18:32Z

This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.

microsoft-github-policy-service · 2023-11-16T09:26:03Z

This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.

microsoft-github-policy-service · 2023-11-23T13:36:41Z

This issue has been marked as "No Activity" as there has been no activity for 6 months. It has been closed for housekeeping purposes.

SteveL-MSFT added the Issue-Code Cleanup the issue is for cleaning up the code with no impact on functionality label Jul 27, 2017

SteveL-MSFT added this to the 6.0.0-HighPriority milestone Jul 27, 2017

iSazonov added the Committee-Reviewed PS-Committee has reviewed this and made a decision label Jul 27, 2017

iSazonov mentioned this issue Jul 27, 2017

Porting Enable-PSRemoting and its Tests #2671

Merged

daxian-dbw mentioned this issue Jul 28, 2017

Remove ClrFacade.GetUninitializedObject and 'if CORECLR' cleanup #4375

Merged

This was referenced Jul 31, 2017

Clean up '#if CORE' in Utils.cs #4397

Merged

Clean up '#if CORE' in CimIndicationWatcher.cs #4398

Merged

Clean up '#if CORE' in PdhSafeHandle.cs #4399

Merged

iSazonov mentioned this issue Oct 4, 2017

Cleanup Json cmdlets #5001

Merged

markekraus mentioned this issue Nov 8, 2017

Clean Up Full CLR Code From Web Cmdlets #5376

Merged

SteveL-MSFT modified the milestones: 6.1.0-Consider, 6.2.0-Consider Apr 26, 2018

SteveL-MSFT modified the milestones: 6.2.0-Consider, Future Jun 21, 2018

This was referenced Nov 23, 2018

Cleanup '#if CORECLR' from some files #8332

Merged

Remove old 'customPSSnapInType' parameter from PSSnapInInfo() #8333

Merged

Cleanup updatablehelpsystem and enable XSD validation on MAML help content #8335

Merged

iSazonov mentioned this issue Nov 26, 2018

Cleanup '#if !CORECLR' code #8337

Merged

11 tasks

rjmholt mentioned this issue Aug 10, 2020

Explicit Add-Type vs Implicit Add-Type Not Documented MicrosoftDocs/PowerShell-Docs#6422

Closed

xtqqczze mentioned this issue Oct 21, 2022

Remove FusionAssemblyIdentity and GlobalAssemblyCache #18334

Merged

22 tasks

microsoft-github-policy-service bot added the Resolution-No Activity Issue has had no activity for 6 months or more label Nov 16, 2023

microsoft-github-policy-service bot removed this from the Future milestone Nov 23, 2023

microsoft-github-policy-service bot closed this as completed Nov 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove FullCLR code #4357

Remove FullCLR code #4357

SteveL-MSFT commented Jul 27, 2017 •

edited

iSazonov commented Jul 27, 2017

iSazonov commented Jul 27, 2017 •

edited

iSazonov commented Jul 27, 2017

iSazonov commented Jul 27, 2017

daxian-dbw commented Jul 27, 2017

SteveL-MSFT commented Jul 27, 2017

iSazonov commented Jul 27, 2017

SteveL-MSFT commented Jul 27, 2017

daxian-dbw commented Jul 27, 2017

daxian-dbw commented Jul 28, 2017

SteveL-MSFT commented Jul 28, 2017

SteveL-MSFT commented Jul 28, 2017

SteveL-MSFT commented Aug 31, 2017

rjmholt commented Apr 3, 2018 •

edited

iSazonov commented Apr 3, 2018 •

edited

bergmeister commented Aug 5, 2018 •

edited

iSazonov commented Aug 9, 2018

iSazonov commented Nov 15, 2018

SteveL-MSFT commented Nov 20, 2018

iSazonov commented Nov 21, 2018

SteveL-MSFT commented Nov 21, 2018

iSazonov commented Nov 26, 2018 •

edited

iSazonov commented Jul 12, 2019

microsoft-github-policy-service bot commented Nov 16, 2023

microsoft-github-policy-service bot commented Nov 16, 2023

microsoft-github-policy-service bot commented Nov 16, 2023

microsoft-github-policy-service bot commented Nov 23, 2023

Remove FullCLR code #4357

Remove FullCLR code #4357

Comments

SteveL-MSFT commented Jul 27, 2017 • edited

Remaining #if [!]CORECLR usages

iSazonov commented Jul 27, 2017

iSazonov commented Jul 27, 2017 • edited

iSazonov commented Jul 27, 2017

iSazonov commented Jul 27, 2017

daxian-dbw commented Jul 27, 2017

SteveL-MSFT commented Jul 27, 2017

iSazonov commented Jul 27, 2017

SteveL-MSFT commented Jul 27, 2017

daxian-dbw commented Jul 27, 2017

daxian-dbw commented Jul 28, 2017

SteveL-MSFT commented Jul 28, 2017

SteveL-MSFT commented Jul 28, 2017

SteveL-MSFT commented Aug 31, 2017

rjmholt commented Apr 3, 2018 • edited

iSazonov commented Apr 3, 2018 • edited

bergmeister commented Aug 5, 2018 • edited

iSazonov commented Aug 9, 2018

iSazonov commented Nov 15, 2018

SteveL-MSFT commented Nov 20, 2018

iSazonov commented Nov 21, 2018

SteveL-MSFT commented Nov 21, 2018

iSazonov commented Nov 26, 2018 • edited

iSazonov commented Jul 12, 2019

microsoft-github-policy-service bot commented Nov 16, 2023

microsoft-github-policy-service bot commented Nov 16, 2023

microsoft-github-policy-service bot commented Nov 16, 2023

microsoft-github-policy-service bot commented Nov 23, 2023

SteveL-MSFT commented Jul 27, 2017 •

edited

Remaining `#if [!]CORECLR` usages

iSazonov commented Jul 27, 2017 •

edited

rjmholt commented Apr 3, 2018 •

edited

iSazonov commented Apr 3, 2018 •

edited

bergmeister commented Aug 5, 2018 •

edited

iSazonov commented Nov 26, 2018 •

edited