Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting Enable-PSRemoting and its Tests #2671

Merged
merged 12 commits into from Aug 8, 2017

Conversation

mirichmo
Copy link
Member

Fixes #1193 for most scenarios. The remaining scenario to be addressed is the Nano Server bring-up scenario. To continue supporting that scenario, I left the Install-PowerShellRemoting script in place.

This change

  1. Ports Enable-PSRemoting and Disable-PSRemoting to PowerShell Core
  2. Adds side-by-side PowerShell Core remoting support to the PSSessionConfiguration cmdlets and PSRemoting cmdlets.
  3. Ports PSSessionConfiguration tests

This change also introduces a behavioral difference. The PSRemoting and PSSessionConfiguration cmdlets are now context-sensitive and only work for endpoints that match the PowerShell type. For example, Get-PSSessionConfiguration, when run in PowerShell Core, will only return PowerShell Core WinRM endpoints. It will only modify PowerShell Core WinRM endpoints and cannot be used to configure Windows PowerShell endpoints.

@vors vors closed this Nov 14, 2016
@vors vors reopened this Nov 14, 2016
@mirichmo mirichmo added this to the 6.0.0-alpha.14 milestone Nov 22, 2016
@PowerShellTeam PowerShellTeam added the Review - Needed The PR is being reviewed label Nov 22, 2016
@lzybkr lzybkr modified the milestones: 6.0.0-beta, 6.0.0-alpha.14 Dec 8, 2016
@chunqingchen
Copy link
Contributor

Can you please resolve the conflict?

@mirichmo
Copy link
Member Author

At some point. I'm trying to find time to resolve the test failures.

@chunqingchen
Copy link
Contributor

cool !

@PaulHigin
Copy link
Contributor

@mirichmo I am not sure how I missed this being assigned to me as a reviewer. But I will review it today.

@mirichmo
Copy link
Member Author

The tests aren't passing yet so it still needs some work. You are always welcome to take a look though

@PaulHigin
Copy link
Contributor

@mirichmo I went through the code changes and made some minor changes in my fork. I also made some fixes in the test file. Overall I think this looks good and is the right way to implement WinRM based remoting enabling and endpoint management. Please see the patch file I sent you offline that has my minor changes.

@mirichmo
Copy link
Member Author

mirichmo commented Aug 7, 2017

@daxian-dbw This is ready for merge now.

@daxian-dbw daxian-dbw merged commit 515a999 into PowerShell:master Aug 8, 2017
@iSazonov
Copy link
Collaborator

iSazonov commented Aug 9, 2017

This change also introduces a behavioral difference

It seems we need update docs - should we set the label?

@iSazonov iSazonov removed the Review - Needed The PR is being reviewed label Aug 9, 2017
@daxian-dbw daxian-dbw added the Documentation Needed in this repo Documentation is needed in this repo label Aug 9, 2017
@daxian-dbw
Copy link
Member

@iSazonov good point. I added the label to both this PR and the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet