New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ArrayList with List<T> #10333
Merged
adityapatwardhan
merged 9 commits into
PowerShell:master
from
iSazonov:cleanup-replace-arraylist
Sep 5, 2019
Merged
Replace ArrayList with List<T> #10333
adityapatwardhan
merged 9 commits into
PowerShell:master
from
iSazonov:cleanup-replace-arraylist
Sep 5, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
added
the
CL-CodeCleanup
Indicates that a PR should be marked as a Code Cleanup change in the Change Log
label
Aug 9, 2019
iSazonov
requested review from
adityapatwardhan,
anmenaga,
daxian-dbw,
JamesWTruher and
PaulHigin
as code owners
August 9, 2019 07:55
iSazonov
force-pushed
the
cleanup-replace-arraylist
branch
2 times, most recently
from
August 9, 2019 12:24
0ac1d7b
to
a2e4fd7
Compare
PoshChan
reviewed
Aug 9, 2019
src/Microsoft.PowerShell.Commands.Management/commands/management/GetContentCommand.cs
Show resolved
Hide resolved
@daxian-dbw @anmenaga Could you please review? |
iSazonov
force-pushed
the
cleanup-replace-arraylist
branch
from
August 30, 2019 07:41
8418d2d
to
0e9857a
Compare
src/Microsoft.PowerShell.Commands.Management/commands/management/GetContentCommand.cs
Show resolved
Hide resolved
src/Microsoft.PowerShell.Commands.Management/commands/management/GetContentCommand.cs
Outdated
Show resolved
Hide resolved
@adityapatwardhan Could you please review the small style PR? |
adityapatwardhan
approved these changes
Sep 5, 2019
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Sep 14, 2019
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CL-CodeCleanup
Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Related #10315
Replace ArrayList where we use it unjustifiably to get more readable and reliable code.
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.