Rename Copy.Item.Tests.ps1 to match naming convention

[romero126]

PR Summary

Rename Copy.Item.Tests.ps1 -> Copy-Item.Tests.ps1
in order to match naming convention inside \test\powershell\Modules\Microsoft.PowerShell.Management

PR Context

All filenames in \test\powershell\Modules\Microsoft.PowerShell.Management use Verb-Command.Tests when naming their files. This one however does not match that standard.

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
    • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
    • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
    • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[iSazonov]

We have many files not matching naming convention.
If we want have a consistency we must fix everything or fix nothing.

[romero126]

I agree completely. However we cant just fix everything all at once.. That's why we need the approach fix it when you see it. :)

[vexx32]

Mm true. I could see fixing the naming on each file in a given folder, doing it one folder at a time, perhaps?

[iSazonov]

I don't see a value from the change because we use modern IDEs with power and fast search, c# plugins allows us to follow by references, also sometimes we have many classes in one file - as result file name lost value but in the same time renaming complicates commit history.

[daxian-dbw]

... in the same time renaming complicates commit history.

I kinda agree with @iSazonov on that. Renaming a file will cause the file history to be "lost" (or to be more accurate, harder to retrieve). So if it's not necessary, maybe we should avoid renaming files.

[vexx32]

Is it so frequent that we need to dig up file history?

The additional time needed to dig up file history is usually not immense, and not needed very often. I would be surprised if that's necessary anywhere near as much as folx need to go looking for the file. Time lost finding the file as it is now v.s. time lost finding the file as it was before the rename weighted depending on frequency of need.

I would argue that having a consistent naming convention will make maintenance easier both for the PS team and folx in the community, especially folx just starting to look at contributing. In my opinion the consistency is valuable here, but y'all may have different ideas. 🙂

[iSazonov]

Is it so frequent that we need to dig up file history?

If you want to get better understanding how a code works you will look history frequently.

[ghost]

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

[daxian-dbw]

Conflicts resolved.
@romero126 Sorry that this PR has been overlooked for so long ...
The general guideline is to avoid renaming files to keep the history handy. But in this particular case, the history is not very interesting. So I decide to take this change.

[daxian-dbw]

The change in this PR has nothing to do with the CI failure, so I will force merge it.

[ghost]

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes