New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ConciseView
to remove unnecessary text and not color entire line in red
#10724
Conversation
don't color the whole line red making it harder to read
Is it common practice to paint in red only an error token and keep comment in white-on-black? |
@iSazonov the problem with that proposal is that some errors don't have a visible token, like |
'^' could be red in the case. |
Just my opinion but ... some red is good to draw your attention ... too much text in red is hard to read / undesirable. Finding the sweet spot in between .... that's the challenge. :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing really blocking
I should have caught those other errors in the previous, sorry
PR Summary
Remove unnecessary text before script path, detect if whole line is emphasized, then don't do any emphasis. Change emphasis color to accent color instead of error color to make it easier to read. Also fixed some typos and disabled strict mode in helper that works with different dynamic objects that puts errors in $error if strict mode is enabled.
Before:
After:
PR Context
Fix #10716
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.