Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check pwsh.exe and pwsh in daily version on Windows #10738

Merged
merged 1 commit into from Oct 10, 2019

Conversation

centreboard
Copy link
Contributor

PR Summary

Check for pwsh.exe on Windows to get the daily version currently installed

PR Context

Improves on #10489
On Windows pwsh doesn't exist so the same daily version was reinstalled when calling
iex "& {$(irm aka.ms/install-powershell.ps1)} -Daily"

PR Checklist

@TravisEz13
Copy link
Member

@iSazonov iSazonov added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Oct 9, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.5 milestone Oct 9, 2019
@centreboard
Copy link
Contributor Author

@TravisEz13 Could you please look at it? I don't have a mac and naively replacing caskroom/cask with homebrew/cask-cask didn't work for me in Azure Pipelines.

@TravisEz13
Copy link
Member

I've opened #10752 to fix the issue. I'll help update this PR once we have fixed that issue.

@TravisEz13
Copy link
Member

The other PR was merged. I retried your test.

@TravisEz13
Copy link
Member

@PoshChan Please remind me in 1 hour

@PoshChan
Copy link
Collaborator

PoshChan commented Oct 9, 2019

@TravisEz13, this is the reminder you requested 1 hour ago

@TravisEz13 TravisEz13 changed the title Check pwsh.exe daily version on Windows Check pwsh.exe and pwsh in daily version on Windows Oct 10, 2019
@TravisEz13 TravisEz13 merged commit 54fd7d8 into PowerShell:master Oct 10, 2019
@TravisEz13
Copy link
Member

Thanks for your contribution

@bergmeister
Copy link
Contributor

Awesome, thanks :-)

@ghost
Copy link

ghost commented Oct 23, 2019

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

kilasuit pushed a commit to kilasuit/PowerShell that referenced this pull request Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Tools Indicates that a PR should be marked as a tools change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants