Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for the even handler leaking fix #10768

Merged
merged 4 commits into from Oct 11, 2019

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Oct 10, 2019

PR Summary

Add a test for the even handler leaking fix addressed in #10626
The test is added to verify that PowerShell unregister the 'AppDomain.ProcessExit' event handler when a Runspace closes.

PR Checklist

@daxian-dbw daxian-dbw added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Oct 10, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.5 milestone Oct 11, 2019
@iSazonov
Copy link
Collaborator

I think we need more info in the PR description for merged commit.

@daxian-dbw
Copy link
Member Author

PR description updated.

@ghost
Copy link

ghost commented Oct 23, 2019

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

kilasuit pushed a commit to kilasuit/PowerShell that referenced this pull request Oct 31, 2019
Add a test for the even handler leaking fix addressed in PowerShell#10626 PowerShell#10626
The test is added to verify that PowerShell unregister the 'AppDomain.ProcessExit' event handler when a Runspace closes.
kilasuit pushed a commit to kilasuit/PowerShell that referenced this pull request Nov 9, 2019
Add a test for the even handler leaking fix addressed in PowerShell#10626 PowerShell#10626
The test is added to verify that PowerShell unregister the 'AppDomain.ProcessExit' event handler when a Runspace closes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Test Indicates that a PR should be marked as a test change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants