New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a regression in formatting caused by the 'FirstOrDefault' primitive added in 7.0.0-Preview1 #11258
Fix a regression in formatting caused by the 'FirstOrDefault' primitive added in 7.0.0-Preview1 #11258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one minor comment.
# Copyright (c) Microsoft Corporation. All rights reserved. | ||
# Licensed under the MIT License. | ||
|
||
Describe 'Bug fixes related to formatting' -Tag CI { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better to have positive and functional names for the file and describe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the test name, but kept the file name unchanged. I would like this file to be used for future bug fixes related to formatting.
…ve added in `7.0.0-Preview1` (#11258)
🎉 Handy links: |
PR Summary
Fix #10554
Hidden members should not be returned by any fuzzy searches, such as searching by 'match' or enumerating the collection. They are returned only if the member names are explicitly looked for.
FirstOrDefault
is a fuzzy search, so it should ignore the hidden members.PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.