Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a regression in formatting caused by the 'FirstOrDefault' primitive added in 7.0.0-Preview1 #11258

Merged
merged 5 commits into from Dec 11, 2019

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Dec 3, 2019

PR Summary

Fix #10554

Hidden members should not be returned by any fuzzy searches, such as searching by 'match' or enumerating the collection. They are returned only if the member names are explicitly looked for. FirstOrDefault is a fuzzy search, so it should ignore the hidden members.

PR Context

PR Checklist

@ghost ghost assigned TravisEz13 Dec 3, 2019
@daxian-dbw daxian-dbw changed the title Fix a regression in formatting caused by the 'FirstOrDefault' primitive added in PowerShell 7 preview Fix a regression in formatting caused by the 'FirstOrDefault' primitive added in 7.0.0-Preview1 Dec 3, 2019
@daxian-dbw daxian-dbw added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Dec 3, 2019
@daxian-dbw daxian-dbw added this to the rc.1-consider milestone Dec 3, 2019
Copy link
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor comment.

# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License.

Describe 'Bug fixes related to formatting' -Tag CI {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to have positive and functional names for the file and describe.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the test name, but kept the file name unchanged. I would like this file to be used for future bug fixes related to formatting.

@adityapatwardhan adityapatwardhan merged commit 5605bf4 into PowerShell:master Dec 11, 2019
@daxian-dbw daxian-dbw deleted the firstordefault branch December 12, 2019 00:10
adityapatwardhan pushed a commit that referenced this pull request Dec 13, 2019
@ghost
Copy link

ghost commented Dec 16, 2019

🎉v7.0.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Engine Indicates that a PR should be marked as an engine change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write-Output of class with hidden params regression in PS 7
6 participants