New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make null member access tests as string to avoid parsing errors #11385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. But are you going to make similar changes to the NullConditionalOperator tests in Parser.Tests.ps1
and the tabcompletion test file?
@daxian-dbw - Added Parsing tests in the PR. |
@PoshChan please retry linux |
@adityapatwardhan, successfully started retry of |
Hello @adityapatwardhan! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
* Make null member access tests as string to avoid parsing errors * Add PSNullConditionalOperators feature to testmetadata.json * Add Parsing tests to be skipped * Add tabcompletion tests
🎉 Handy links: |
PR Summary
Fixes #11354
PSNullConditionalOperators
feature is disabled by default. Hence it causes parsing error when tests are run. This PR converts the tests into here strings and executes them if the feature is enabled.PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.