Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize line endings before comparing string in tests #11499

Merged

Conversation

adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Jan 6, 2020

PR Summary

Fix tests which fail on comparing string due to differences in line endings.

PR Context

PR Checklist

@ghost ghost assigned adityapatwardhan Jan 6, 2020
@adityapatwardhan adityapatwardhan added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jan 6, 2020
@adityapatwardhan adityapatwardhan added this to the GA-consider milestone Jan 6, 2020
@@ -5,6 +5,15 @@ Describe 'Basic debugger command tests' -tag 'CI' {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityapatwardhan, your last commit had 1 failures in PowerShell-CI-static-analysis
Verify Markdown Links.Verify links in /home/vsts/work/1/s/docs/debugging/README.md.https://blogs.msdn.microsoft.com/visualstudioalm/2016/03/10/experimental-net-core-debugging-in-vs-code/ should work

Failed to complete request to "https://blogs.msdn.microsoft.com/visualstudioalm/2016/03/10/experimental-net-core-debugging-in-vs-code/". Response status code does not indicate success: 410 (Gone).
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 119
119:                                     throw "Failed to complete request to `"$url`". $($_.Exception.Message)"

@adityapatwardhan
Copy link
Member Author

@PoshChan please retry static

@PoshChan
Copy link
Collaborator

PoshChan commented Jan 6, 2020

@adityapatwardhan, successfully started retry of PowerShell-CI-static-analysis

@@ -5,6 +5,15 @@ Describe 'Basic debugger command tests' -tag 'CI' {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityapatwardhan, your last commit had 2 failures in PowerShell-CI-static-analysis
Verify Markdown Links.Verify links in /home/vsts/work/1/s/docs/debugging/README.md.https://blogs.msdn.microsoft.com/visualstudioalm/2016/03/10/experimental-net-core-debugging-in-vs-code/ should work

Failed to complete request to "https://blogs.msdn.microsoft.com/visualstudioalm/2016/03/10/experimental-net-core-debugging-in-vs-code/". Response status code does not indicate success: 404 (Not Found).
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 119
119:                                     throw "Failed to complete request to `"$url`". $($_.Exception.Message)"

Verify Markdown Links.Verify links in /home/vsts/work/1/s/docs/debugging/README.md.https://blogs.msdn.microsoft.com/visualstudioalm/2016/03/10/experimental-net-core-debugging-in-vs-code/ should work

Failed to complete request to "https://blogs.msdn.microsoft.com/visualstudioalm/2016/03/10/experimental-net-core-debugging-in-vs-code/". Response status code does not indicate success: 410 (Gone).
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 119
119:                                     throw "Failed to complete request to `"$url`". $($_.Exception.Message)"

@adityapatwardhan
Copy link
Member Author

@PoshChan Please rebuild static

@PoshChan
Copy link
Collaborator

PoshChan commented Jan 6, 2020

@adityapatwardhan, successfully started rebuild of PowerShell-CI-static-analysis

@adityapatwardhan
Copy link
Member Author

@TravisEz13 Can you have a look

@adityapatwardhan adityapatwardhan merged commit 0097802 into PowerShell:master Jan 8, 2020
@daxian-dbw daxian-dbw modified the milestones: GA-approved, 7.0.0-rc.2 Jan 14, 2020
@ghost
Copy link

ghost commented Jan 16, 2020

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Test Indicates that a PR should be marked as a test change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants