-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extra line before formatting group #12163
Conversation
src/System.Management.Automation/FormatAndOutput/common/BaseFormattingCommand.cs
Show resolved
Hide resolved
src/System.Management.Automation/FormatAndOutput/common/BaseFormattingCommand.cs
Show resolved
Hide resolved
src/System.Management.Automation/FormatAndOutput/common/BaseFormattingCommand.cs
Show resolved
Hide resolved
src/System.Management.Automation/FormatAndOutput/common/BaseFormattingCommand.cs
Show resolved
Hide resolved
cb52a75
to
76b436b
Compare
src/System.Management.Automation/FormatAndOutput/common/BaseFormattingCommand.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
although we don't usually have validation for formatting, it would be useful to have the discussion include what this looks like now vs your fix with some sample output.
src/System.Management.Automation/FormatAndOutput/common/BaseFormattingCommand.cs
Show resolved
Hide resolved
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
The PR removes first extra empty line - you can see screenshots in related issue. |
@SteveL-MSFT @JamesWTruher Can you update your review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine, it should probably done for format-list too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve as maintainer
It would be good to audit the rest of the system. IMO gci still outputs several unnecessary new lines, which makes it too verbose. Clearly this PR is the correct fix, but future exploring this has utility. |
@musm If you don't see already opened issues for broken formatting please open new ones. |
WIll do, Thanks for this fix! |
🎉 Handy links: |
PR Summary
Fix #11846.
Add newline only before each formatting group except first.
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.