New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put symbols in separate package #12169
Merged
TravisEz13
merged 10 commits into
PowerShell:master
from
TravisEz13:don't_put_symbols_in_MSI
Mar 21, 2020
Merged
Put symbols in separate package #12169
TravisEz13
merged 10 commits into
PowerShell:master
from
TravisEz13:don't_put_symbols_in_MSI
Mar 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
requested review from
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
March 20, 2020 23:07
ghost
assigned daxian-dbw
Mar 20, 2020
TravisEz13
added
the
CL-BuildPackaging
Indicates that a PR should be marked as a build or packaging change in the Change Log
label
Mar 21, 2020
daxian-dbw
approved these changes
Mar 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except one minor comment: mandatory parameter doesn’t need the nullorempty validation.
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CL-BuildPackaging
Indicates that a PR should be marked as a build or packaging change in the Change Log
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Put symbols is separate zip package
PR Context
We only have one manifest for the x86 and x64 msi. So the package content cannot vary
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.