Fix path handling bug in PSTask

[IISResetMe]

PR Summary

This PR changes the behavior PSTask to always treat the current $PWD as a literal path, in turn allowing ForEach-Object -Parallel to execute correctly when invoked from a path with wildcard characters in the name.

PR Context

Fixes #12428

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
    • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
    • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
    • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[vexx32]

Looks good to me, nice work!

Tests look good I think, just noticed a small style thing in one section that's really bugging me, but nothing serious. 😁

[iSazonov]

@IISResetMe I have started a code review and discover that the fix is only partial. I found at least two scenario where wildcards broke set location:

1. Create [] dir, change dir to the directory, then run cd -; cd +
2. Create [] dir, change dir to the directory, then run pwsh - current directory will be pwsh home, not [].

Result of my investigations is in https://github.com/iSazonov/PowerShell/tree/fix-cd-literalpath
I was very grateful to you if you took this and supplemented with tests (maybe in new PR).

GitHub

iSazonov/PowerShell

PowerShell for every system! Contribute to iSazonov/PowerShell development by creating an account on GitHub.

[adityapatwardhan]

@IISResetMe Please fix the CodeFactor issues.

[iSazonov]

I think it makes no sense to merge the PR because follow more general fix will revert it - the general fix is in another place.

[IISResetMe]

@iSazonov I... really don't care 😅 as long as #12428 gets fixed

[iSazonov]

@IISResetMe Do you want to work on general fix?

[IISResetMe]

Yeah I can do a broader patch for this and related behavior, but might take a few days, looks like LiteralPath support has been neglected all over the place 😒

[adityapatwardhan]

@IISResetMe Thanks for your contribution!

[ghost]

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes