Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required Visual Studio version in build docs #12628

Merged
1 commit merged into from
May 18, 2020

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented May 12, 2020

PR Summary

  • Update build docs to specify Visual Studio 2019 16.6 Preview 2 as a requirement, due to the of net5.0 TFM.
  • Remove dependancy on "Common Tools for Visual C++" as there is no longer C++ code in the repository.

PR Context

Visual Studio 2019 >= 16.6 Preview 2 is required since #12486.
see also: #12514

PR Checklist

@iSazonov iSazonov added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label May 12, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.3 milestone May 12, 2020
@xtqqczze
Copy link
Contributor Author

@TravisEz13 ready to merge

@iSazonov iSazonov added the AutoMerge informs the bot to automerge the PR label May 18, 2020
@ghost
Copy link

ghost commented May 18, 2020

Hello @iSazonov!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit e5bd233 into PowerShell:master May 18, 2020
@xtqqczze xtqqczze deleted the building-windows-docs branch May 18, 2020 17:07
@ghost
Copy link

ghost commented Jun 25, 2020

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

@xtqqczze xtqqczze mentioned this pull request Jun 29, 2020
14 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge informs the bot to automerge the PR CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants